Bug Tracker

Opened 11 years ago

Closed 9 years ago

#3194 closed enhancement (invalid)

Possible optimization for the selector module

Reported by: flesler Owned by: flesler
Priority: minor Milestone: 1.3
Component: selector Version: 1.2.6
Keywords: attr Cc:
Blocked by: Blocking:

Description

This reduces the code size and makes things more straight forward. But could be slower than the actual code...

Attachments (1)

selector[5795].diff (600 bytes) - added by flesler 11 years ago.

Download all attachments as: .zip

Change History (6)

Changed 11 years ago by flesler

Attachment: selector[5795].diff added

comment:1 Changed 11 years ago by flesler

This adds a LOT of overhead :(

comment:2 Changed 11 years ago by joern

Resolution: invalid
Status: newclosed

The performance overhead isn't worth the code improvement.

comment:3 Changed 11 years ago by joern

Resolution: invalid
Status: closedreopened

The code to be removed is redundant with attr, maybe a refactoring is a better approach.

comment:4 Changed 11 years ago by flesler

I don't see why "redundant". Using attr() is the logical approach, it just adds too much overhead.

comment:5 Changed 9 years ago by dmethvin

Resolution: invalid
Status: reopenedclosed

This doesn't apply anymore since Sizzle was introduced.

Note: See TracTickets for help on using tickets.