Opened 11 years ago
Closed 10 years ago
#3194 closed enhancement (invalid)
Possible optimization for the selector module
| Reported by: | flesler | Owned by: | flesler |
|---|---|---|---|
| Priority: | minor | Milestone: | 1.3 |
| Component: | selector | Version: | 1.2.6 |
| Keywords: | attr | Cc: | |
| Blocked by: | Blocking: |
Description
This reduces the code size and makes things more straight forward. But could be slower than the actual code...
Attachments (1)
Change History (6)
Changed 11 years ago by
| Attachment: | selector[5795].diff added |
|---|
comment:1 Changed 11 years ago by
comment:2 Changed 11 years ago by
| Resolution: | → invalid |
|---|---|
| Status: | new → closed |
The performance overhead isn't worth the code improvement.
comment:3 Changed 11 years ago by
| Resolution: | invalid |
|---|---|
| Status: | closed → reopened |
The code to be removed is redundant with attr, maybe a refactoring is a better approach.
comment:4 Changed 11 years ago by
I don't see why "redundant". Using attr() is the logical approach, it just adds too much overhead.
comment:5 Changed 10 years ago by
| Resolution: | → invalid |
|---|---|
| Status: | reopened → closed |
This doesn't apply anymore since Sizzle was introduced.
Note: See
TracTickets for help on using
tickets.
This adds a LOT of overhead :(