Bug Tracker

Opened 11 years ago

Closed 8 years ago

#2192 closed bug (fixed)

strict ~= selector

Reported by: cloudream Owned by: flesler
Priority: minor Milestone: 1.3
Component: selector Version: 1.2.2
Keywords: Cc: cloudream
Blocked by: Blocking:

Description

strict ~= different from *=

Original: ​http://labs.cloudream.name/jquery/~=selector.html

Modify: ​http://labs.cloudream.name/jquery/~=selector2.html

Attachments (2)

selector.diff​ (557 bytes) - added by cloudream 11 years ago.
patch for /src/selector.js
2192.diff​ (5.0 KB) - added by nathanhammond 11 years ago.
Patch.

Download all attachments as: .zip

Change History (6)

Changed 11 years ago by cloudream

Attachment: selector.diff​ added

patch for /src/selector.js

comment:1 Changed 11 years ago by davidserduke

Type: enhancement → bug

comment:2 Changed 11 years ago by flesler

Cc: cloudream added
Component: core → selector
Milestone: 1.2.3 → 1.3
need: Review → Patch
Owner: set to flesler
Status: new → assigned

Changed 11 years ago by nathanhammond

Attachment: 2192.diff​ added

Patch.

comment:3 Changed 11 years ago by nathanhammon

I've attached a patch that not only adds support for ~=, but also |=. The only compromise for more common selectors is on file size, and for efficiency, the worst one (|=) gets tested last.

The patch includes updates to the test suite to add tests for these new selectors and updates existing tests where results didn't match anymore.

This should close #2192, #2640, and #2856.

comment:4 Changed 8 years ago by jitter

Resolution: → fixed
Status: assigned → closed

Correct me if I'm wrong but this should be fixed since approx. jQuery 1.3

Note: See TracTickets for help on using tickets.