Error using "jquery/ajax" with AMD

[tj.vantoll]

I'm trying to create snippets of how to use pieces of jQuery outside of the whole library. For a basic AJAX call I'm attempting to use the following:

define([ "jquery/ajax" ], function( $ ) {
	$.ajax( "http://whatever" );
});

But I get an error on ​this line because jQuery.event is undefined. If I use this block the call works:

define([ "jquery/event", "jquery/ajax/xhr" ], function( $ ) {
	$.get( "http://whatever" );
});

So my question is: should ajax.js depend on event.js?

[dmethvin]

Ugh. Well technically yes, you need event. However I think all the event work it does is guarded by the global option which defaults to true. So if you pass in global: false it won't try to trigger ajax events.

It seems like one solution here would be to check for jQuery.event and skip firing global events if it's not defined. There can't possibly be anyone listening for the event if that's the case, right?

[tj.vantoll]

I verified that setting global to false avoids this problem.

This is tricky, but I think a quick check for jQuery.event is a good idea. 99.9% of people are not micromanaging Core, and for those that are, it'd be nice to see $.ajax streamlined (and small in terms of bytes).

I'll put a PR together.

[dmethvin]

I think it's a really quick extra conditional to ​where we set `fireGlobals`

[tj.vantoll]

PR: ​https://github.com/jquery/jquery/pull/1588

[TJ VanToll]

Ajax: Support usage without jQuery.event

Fixes #15118 Closes gh-1588

Changeset: d41e81980ea89e56c04eb14d8c27f4692b367604