Opened 9 years ago
Closed 9 years ago
#14915 closed bug (fixed)
Warn if Sizzle isn't the most recent tag during a release
Reported by: | dmethvin | Owned by: | timmywil |
---|---|---|---|
Priority: | blocker | Milestone: | 1.12/2.2 |
Component: | build | Version: | 1.11.0 |
Keywords: | Cc: | ||
Blocked by: | Blocking: |
Description (last modified by )
Or something. Our Sizzle was way out of date for the beta1 releases but there was no noise about it.
Change History (9)
comment:1 Changed 9 years ago by
Component: | unfiled → build |
---|---|
Milestone: | None → 1.11.1/2.1.1 |
Priority: | undecided → blocker |
Status: | new → open |
comment:2 Changed 9 years ago by
Description: | modified (diff) |
---|---|
Owner: | set to timmywil |
Status: | open → assigned |
Summary: | Don't allow release if Sizzle isn't the most recent → Warn if Sizzle isn't the most recent tag during a release |
comment:3 Changed 9 years ago by
I agree with your logic timmywil, and as you said in IRC the main problem is that we made several commits without any corresponding jQuery ticket that would have pulled them over.
If we had discovered this during a release the right procedure would have been to stop the release and pull in Sizzle, then do unit tests. I just wondered if there is anything we need to do in addition during day-to-day work to ensure we don't get out of sync again.
comment:4 follow-up: 5 Changed 9 years ago by
Perhaps we should replicate relevant Sizzle issues with jQuery tickets. It's appropriate that Sizzle have its own issues, but any issue that affects jQuery should correspond to a jQuery ticket. That ticket would then be closed by an "Update Sizzle" commit.
comment:5 Changed 9 years ago by
dmethvin: I didn't realize until seeing it spelled out here that we were previously talking past each other a little bit. jQuery should always be able to reference the latest Sizzle tag, not commit (and should also be free to use an older tag, but I can't remember any situation when we would have wanted to).
any issue that affects jQuery should correspond to a jQuery ticket. That ticket would then be closed by an "Update Sizzle" commit.
I agree. #14901 was in fact such a ticket; it was just closed prematurely because there were also changes required in the jQuery source.
comment:6 Changed 9 years ago by
I think I confused things a bit, I *was* originally thinking last commit but agree it should be last tag. Having jquery-release give a non-fatal warning about there being commits on Sizzle past the last tag would be "thing that makes you go hmmm" and worth thinking about before proceeding, but not a fatal thing.
comment:7 Changed 9 years ago by
Milestone: | 1.11.1/2.1.1 → 1.12/2.2 |
---|
comment:8 Changed 9 years ago by
The work is completed, but the commit is dependent on a pull request on jquery-release.
comment:9 Changed 9 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Release: ensure Sizzle is the latest tag
Fixes #14915
Changeset: 1d931068d30b6a516b883cf7f420606de21eab68
Sizzle can be purposefully ahead of jQuery, and that's okay. It should not be inexorably forced upon a release. However, under no circumstances should jQuery blindly include the latest master of Sizzle. There are many reasons for this. Here are a couple: