Bug Tracker

Opened 3 years ago

Closed 3 years ago

#14687 closed feature (fixed)

note on AMD best practices

Reported by: andrew@… Owned by:
Priority: low Milestone: 1.11.1/2.1.1
Component: core Version:
Keywords: docs Cc:
Blocked by: Blocking:

Description

Not surprisingly, jQuery has become the go-to example for developers looking to add an AMD definition to their library. As we know, jQuery's near ubiquity means that certain AMD recommendations are not practical for jQuery. Unfortunately, the jQuery named module registration is referenced with the (reasonable) assumption that it's representative of AMD best practices. I'm hoping an extra comment will make it clear that jQuery is a special case.

See https://github.com/jquery/jquery/pull/1478 for the patch and links to related discussions.

Change History (4)

comment:1 Changed 3 years ago by markelog

  • Keywords docs added
  • Priority changed from undecided to low
  • Status changed from new to open
  • Type changed from bug to feature

comment:2 Changed 3 years ago by timmywil

  • Component changed from unfiled to core

comment:3 Changed 3 years ago by dmethvin

  • Milestone changed from None to 1.11.1/2.1.1

comment:4 Changed 3 years ago by S. Andrew Sheppard

  • Resolution set to fixed
  • Status changed from open to closed

AMD: Note on AMD best practices

Fixes #14687 Closes gh-1478

Changeset: 2585ee58809c22a3c97f87b1b4aa68dbd41f386c

Note: See TracTickets for help on using tickets.