Skip to main content

Bug Tracker

Side navigation

#14645 closed bug (fixed)

Opened December 20, 2013 11:10PM UTC

Closed December 20, 2013 11:42PM UTC

Remove global exposure for CommonJS environments with a document

Reported by: timmywil Owned by: timmywil
Priority: blocker Milestone: 1.11/2.1
Component: core Version: 2.1.0-beta2
Keywords: Cc:
Blocked by: Blocking:

Browser emulators still need the globals, but we can use the same check we use on load to limit global exposure for the most common CommonJS use cases.

Attachments (0)
Change History (2)

Changed December 20, 2013 11:11PM UTC by timmywil comment:1

component: unfiledcore
milestone: None1.11/2.1
owner: → timmywil
priority: undecidedblocker
status: newassigned

Changed December 20, 2013 11:42PM UTC by Timmy Willison comment:2

resolution: → fixed
status: assignedclosed

exports/global: Do not attach global variables for most CommonJS environments

For CommonJS environments where the global already has a document, it is expected

that if a global is needed, the user can attach the global.

Fixes #14645.

Changeset: e0fad093b63d2d197a9c59ccce8896d75a83c95e