Bug Tracker

Opened 4 years ago

Closed 4 years ago

#14645 closed bug (fixed)

Remove global exposure for CommonJS environments with a document

Reported by: timmywil Owned by: timmywil
Priority: blocker Milestone: 1.11/2.1
Component: core Version: 2.1.0-beta2
Keywords: Cc:
Blocked by: Blocking:

Description

Browser emulators still need the globals, but we can use the same check we use on load to limit global exposure for the most common CommonJS use cases.

Change History (2)

comment:1 Changed 4 years ago by timmywil

Component: unfiledcore
Milestone: None1.11/2.1
Owner: set to timmywil
Priority: undecidedblocker
Status: newassigned

comment:2 Changed 4 years ago by Timmy Willison

Resolution: fixed
Status: assignedclosed

exports/global: Do not attach global variables for most CommonJS environments

For CommonJS environments where the global already has a document, it is expected that if a global is needed, the user can attach the global.

Fixes #14645.

Changeset: e0fad093b63d2d197a9c59ccce8896d75a83c95e

Note: See TracTickets for help on using tickets.