Opened 10 years ago
Closed 10 years ago
#14645 closed bug (fixed)
Remove global exposure for CommonJS environments with a document
Reported by: | Timmy Willison | Owned by: | Timmy Willison |
---|---|---|---|
Priority: | blocker | Milestone: | 1.11/2.1 |
Component: | core | Version: | 2.1.0-beta2 |
Keywords: | Cc: | ||
Blocked by: | Blocking: |
Description
Browser emulators still need the globals, but we can use the same check we use on load to limit global exposure for the most common CommonJS use cases.
Change History (2)
comment:1 Changed 10 years ago by
Component: | unfiled → core |
---|---|
Milestone: | None → 1.11/2.1 |
Owner: | set to Timmy Willison |
Priority: | undecided → blocker |
Status: | new → assigned |
comment:2 Changed 10 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Note: See
TracTickets for help on using
tickets.
exports/global: Do not attach global variables for most CommonJS environments
For CommonJS environments where the global already has a document, it is expected that if a global is needed, the user can attach the global.
Fixes #14645.