Skip to main content

Bug Tracker

Side navigation

#14544 closed feature (fixed)

Opened November 14, 2013 05:26PM UTC

Closed November 14, 2013 08:05PM UTC

Remove elem reference from event handler

Reported by: dmethvin Owned by: dmethvin
Priority: low Milestone: 2.1
Component: event Version: 1.10.2
Keywords: Cc:
Blocked by: Blocking:
Description

The reference to the element being handled at https://github.com/jquery/jquery/blob/7f0b28e3083ab8e755801823166e1b008d128242/src/event.js#L80 was there to prevent oldIE leaks so it can be removed in master.

This change will also be useful if we attach data directly to elements, because we may be able to get away with only calling teardown for special events rather than all events on discarded elements.

PR: https://github.com/jquery/jquery/pull/1400

Attachments (0)
Change History (3)

Changed November 14, 2013 05:27PM UTC by dmethvin comment:1

component: unfiledevent
milestone: None2.1
owner: → dmethvin
priority: undecidedlow
status: newassigned
type: bugfeature

Changed November 14, 2013 06:43PM UTC by dmethvin comment:2

Ref #11570

Changed November 14, 2013 08:05PM UTC by Ilya Kantor comment:3

resolution: → fixed
status: assignedclosed

Event: Fix #14544. Remove elem from event handle, close gh-1400.

This also reduces memory leaks if the element is removed without cleaning

events (e.g with native DOM operations).

Not pickable into the 1.x branch because oldIE still needs this.

Changeset: d0782ed7e81a181f0541e1ce7c8cba0825a80299