Bug Tracker

Opened 14 years ago

Closed 14 years ago

#1449 closed bug (fixed)

parent method return duplicate elements

Reported by: blairmitchelmore Owned by:
Priority: minor Milestone: 1.1.4
Component: core Version: 1.1.3
Keywords: Cc:
Blocked by: Blocking:

Description

When you have multiple elements from the same parent elements in a jQuery array and then call parent, the resultant jQuery array contains multiple references to the same element.

Test case found at http://jquery.offput.ca/tests/parent.php

The page will alert '6' and it should alert '1'

Attachments (1)

1449.diff (335 bytes) - added by blairmitchelmore 14 years ago.
Fix for #1449

Download all attachments as: .zip

Change History (3)

comment:1 Changed 14 years ago by blairmitchel

I've fixed the bug (if it is a bug and not a "feature") but simply calling jQuery.unique inside the .parent() method.

                var ret = jQuery.map(this,n);
                if ( a && typeof a == "string" )
                        ret = jQuery.multiFilter(a,ret);
-               return this.pushStack( ret );
+               return this.pushStack( jQuery.unique(ret) );
        };
 });

I don't see any major consequences from this and it would be an easy patch for jQuery core. (Of course you could also patch pushStack to ensure things are unique, but that could be overkill.)

Changed 14 years ago by blairmitchelmore

Attachment: 1449.diff added

Fix for #1449

comment:2 Changed 14 years ago by john

Resolution: fixed
Status: newclosed

Fixed in SVN rev [2769].

Note: See TracTickets for help on using tickets.