#14313 closed bug (fixed)
Optimize jQuery.merge for size
Reported by: | Owned by: | ||
---|---|---|---|
Priority: | low | Milestone: | 2.1 |
Component: | core | Version: | 2.0.3 |
Keywords: | Cc: | ||
Blocked by: | Blocking: |
Description
- Use
+
operator instead oftypeof === "number"
- Eliminate oldIE specific
else
condition
Change History (9)
comment:1 Changed 9 years ago by
Component: | unfiled → core |
---|---|
Priority: | undecided → low |
Status: | new → open |
comment:2 Changed 9 years ago by
Owner: | set to [email protected]… |
---|---|
Status: | open → assigned |
comment:3 Changed 9 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Fix #14313: Optimize jQuery.merge for size. Close gh-1344.
Changeset: c75c9a8ebb5d2483daa68bec799e0d770083a811
comment:4 Changed 9 years ago by
Ref #14313: Further code and test improvements
Changeset: f66d53c85643e703a8e37d9ca9375dd386a60cda
comment:5 Changed 9 years ago by
Ref #14313: NaN detection. Close gh-1352. (cherry picked from commit 0bc0a69026ce4c1ac570a729d3c975a4a55d0ff4)
Changeset: 68213f20bb5d5426f99bafde028ecab601a9d105
comment:6 Changed 9 years ago by
Milestone: | None → 2.1 |
---|
comment:7 Changed 9 years ago by
http://jsperf.com/typeof-number-vs-unary-plus/5
Replying to [email protected]…:
- Use
+
operator instead oftypeof === "number"
- Eliminate oldIE specific
else
condition
comment:8 Changed 9 years ago by
I just ran that perf in Chrome 31 and typeof is waaaaay faster (55x to be exact) than the unary version. Is this change definitely worthwhile?
comment:9 Changed 9 years ago by
This is an old closed ticket. If you have a proposed change, please put together a pull request, jsperf, and new ticket.
Related: https://github.com/jquery/jquery/pull/1344