Bug Tracker

Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#14313 closed bug (fixed)

Optimize jQuery.merge for size

Reported by: [email protected]… Owned by: [email protected]…
Priority: low Milestone: 2.1
Component: core Version: 2.0.3
Keywords: Cc:
Blocked by: Blocking:

Description

  • Use + operator instead of typeof === "number"
  • Eliminate oldIE specific else condition

Change History (9)

comment:1 Changed 8 years ago by timmywil

Component: unfiled → core
Priority: undecided → low
Status: new → open

Related: ​https://github.com/jquery/jquery/pull/1344

comment:2 Changed 8 years ago by timmywil

Owner: set to [email protected]…
Status: open → assigned

comment:3 Changed 8 years ago by Amey Sakhadeo

Resolution: → fixed
Status: assigned → closed

Fix #14313: Optimize jQuery.merge for size. Close gh-1344.

Changeset: c75c9a8ebb5d2483daa68bec799e0d770083a811

comment:4 Changed 8 years ago by Richard Gibson

Ref #14313: Further code and test improvements

Changeset: f66d53c85643e703a8e37d9ca9375dd386a60cda

comment:5 Changed 8 years ago by Richard Gibson

Ref #14313: NaN detection. Close gh-1352. (cherry picked from commit 0bc0a69026ce4c1ac570a729d3c975a4a55d0ff4)

Changeset: 68213f20bb5d5426f99bafde028ecab601a9d105

comment:6 Changed 8 years ago by dmethvin

Milestone: None → 2.1

comment:7 in reply to:  description Changed 8 years ago by anonymous

​http://jsperf.com/typeof-number-vs-unary-plus/5

Replying to [email protected]…:

  • Use + operator instead of typeof === "number"
  • Eliminate oldIE specific else condition

comment:8 Changed 8 years ago by [email protected]…

I just ran that perf in Chrome 31 and typeof is waaaaay faster (55x to be exact) than the unary version. Is this change definitely worthwhile?

comment:9 Changed 8 years ago by dmethvin

This is an old closed ticket. If you have a proposed change, please put together a pull request, jsperf, and new ticket.

Note: See TracTickets for help on using tickets.