Skip to main content

Bug Tracker

Side navigation

#14164 closed bug (fixed)

Opened July 22, 2013 09:15PM UTC

Closed September 16, 2013 08:02PM UTC

Reduce forced layout reflows in init or methods

Reported by: dmethvin Owned by:
Priority: blocker Milestone: 1.11/2.1
Component: core Version: 1.10.2
Keywords: Cc:
Blocked by: Blocking:

This is a meta-ticket for identifying and solving issues with feature detects or other code that may be forcing layout and impacting performance.

Some of the issues may be resolved via documentation.

Attachments (0)
Change History (8)

Changed July 22, 2013 09:18PM UTC by dmethvin comment:1

blockedby: → 10814, 14147
component: unfiledcore
milestone: None1.11/2.1
priority: undecidedblocker
status: newopen

Changed July 30, 2013 01:18PM UTC by dmethvin comment:2

See comment 52 in #5087, checking for the className before removing it saves a reflow if the class isn't there.

Changed August 19, 2013 03:57PM UTC by Jeremy Dunck comment:3

resolution: → fixed
status: openclosed

Fix #14164: assign className in addClass/removeClass only if changed. Close gh-1331.

Changeset: c418b94eb48188cd9329519ae5e030a52dd81cc9

Changed August 19, 2013 04:21PM UTC by m_gol comment:4

resolution: fixed
status: closedreopened

Crap, wrong ticket.

Changed August 19, 2013 04:23PM UTC by dmethvin comment:5

status: reopenedopen

Correct ticket for that changeset is #14250

Changed September 16, 2013 05:16PM UTC by m_gol comment:6

Is it still relevant after support refactor?

Changed September 16, 2013 08:01PM UTC by dmethvin comment:7

blockedby: 10814, 14147

It's blocked by an open ticket, but it is probably better to handle the others on a case-by-case basis rather than a meta-ticket.

Changed September 16, 2013 08:02PM UTC by dmethvin comment:8

resolution: → fixed
status: openclosed