Bug Tracker

Opened 3 years ago

Closed 2 years ago

#14164 closed bug (fixed)

Reduce forced layout reflows in init or methods

Reported by: dmethvin Owned by:
Priority: blocker Milestone: 1.11/2.1
Component: core Version: 1.10.2
Keywords: Cc:
Blocked by: Blocking:

Description

This is a meta-ticket for identifying and solving issues with feature detects or other code that may be forcing layout and impacting performance.

Some of the issues may be resolved via documentation.

Change History (8)

comment:1 Changed 3 years ago by dmethvin

  • Blocked by 10814, 14147 added
  • Component changed from unfiled to core
  • Milestone changed from None to 1.11/2.1
  • Priority changed from undecided to blocker
  • Status changed from new to open

comment:2 Changed 3 years ago by dmethvin

See comment 52 in #5087, checking for the className before removing it saves a reflow if the class isn't there.

comment:3 Changed 2 years ago by Jeremy Dunck

  • Resolution set to fixed
  • Status changed from open to closed

Fix #14164: assign className in addClass/removeClass only if changed. Close gh-1331.

Changeset: c418b94eb48188cd9329519ae5e030a52dd81cc9

comment:4 Changed 2 years ago by m_gol

  • Resolution fixed deleted
  • Status changed from closed to reopened

Crap, wrong ticket.

comment:5 Changed 2 years ago by dmethvin

  • Status changed from reopened to open

Correct ticket for that changeset is #14250

comment:6 Changed 2 years ago by m_gol

Is it still relevant after support refactor?

comment:7 Changed 2 years ago by dmethvin

  • Blocked by 10814, 14147 removed

It's blocked by an open ticket, but it is probably better to handle the others on a case-by-case basis rather than a meta-ticket.

comment:8 Changed 2 years ago by dmethvin

  • Resolution set to fixed
  • Status changed from open to closed
Note: See TracTickets for help on using tickets.