Skip to main content

Bug Tracker

Side navigation

#14040 closed bug (fixed)

Opened June 19, 2013 10:02AM UTC

Closed December 23, 2013 10:38PM UTC

Last modified December 23, 2013 10:43PM UTC

Tests: Replace QUnit.reset usage

Reported by: jzaefferer Owned by:
Priority: high Milestone: 1.11/2.1
Component: misc Version: 1.10.1
Keywords: Cc:
Blocked by: Blocking:

QUnit.reset is deprecated, and will be removed eventually:

jQuery Core currently uses QUnit.reset() within several tests, and uses it as a hook for custom resets. Both need to be replaced.

For the QUnit.reset usage within tests: Split those tests into individual test calls.

For the QUnit.reset "enhancement" in testrunner.js: Use QUnit.testDone(function() { ... }); for custom resets. This needs to happen after all direct usage for QUnit.reset is gone, to work properly.

I'm happy to help with this, but need support from someone who's (more) familiar with the testsuite.

Attachments (0)
Change History (3)

Changed June 23, 2013 04:14PM UTC by dmethvin comment:1

component: unfiledmisc
priority: undecidedhigh
status: newopen

Yeah, those tests are from long ago and I'm not sure why they were done like that. Seems like it should be relatively easy to split them up.

Changed December 23, 2013 10:38PM UTC by cjqed comment:2

resolution: → fixed
status: openclosed

Tests: Avoid use of QUnit.reset() in tests by splitting them

Fix #14040

Close gh-1457

Changeset: 537e9ced6164074c32df429bb1fa4c30361aa711

Changed December 23, 2013 10:43PM UTC by dmethvin comment:3

milestone: None1.11/2.1