Bug Tracker

Opened 4 years ago

Closed 3 years ago

Last modified 3 years ago

#14040 closed bug (fixed)

Tests: Replace QUnit.reset usage

Reported by: jzaefferer Owned by:
Priority: high Milestone: 1.11/2.1
Component: misc Version: 1.10.1
Keywords: Cc:
Blocked by: Blocking:

Description

QUnit.reset is deprecated, and will be removed eventually: https://github.com/jquery/qunit/issues/354

jQuery Core currently uses QUnit.reset() within several tests, and uses it as a hook for custom resets. Both need to be replaced.

For the QUnit.reset usage within tests: Split those tests into individual test calls.

For the QUnit.reset "enhancement" in testrunner.js: Use QUnit.testDone(function() { ... }); for custom resets. This needs to happen after all direct usage for QUnit.reset is gone, to work properly.

I'm happy to help with this, but need support from someone who's (more) familiar with the testsuite.

Change History (3)

comment:1 Changed 4 years ago by dmethvin

Component: unfiledmisc
Priority: undecidedhigh
Status: newopen

Yeah, those tests are from long ago and I'm not sure why they were done like that. Seems like it should be relatively easy to split them up.

comment:2 Changed 3 years ago by cjqed

Resolution: fixed
Status: openclosed

Tests: Avoid use of QUnit.reset() in tests by splitting them

Fix #14040 Close gh-1457

Changeset: 537e9ced6164074c32df429bb1fa4c30361aa711

comment:3 Changed 3 years ago by dmethvin

Milestone: None1.11/2.1
Note: See TracTickets for help on using tickets.