SourceMap on Google is broken

[mattrobenolt]

​http://ajax.googleapis.com/ajax/libs/jquery/2.0.0/jquery.min.map

That file is incorrect for the url it's at. It's referencing the source, ​http://ajax.googleapis.com/ajax/libs/jquery/2.0.0/jquery-2.0.0.js, which is a 404.

This soucemap looks like it was built for ​http://code.jquery.com/jquery-2.0.0.js.

See: ​http://sourcemap-validator.herokuapp.com/validate?url=http%3A%2F%2Fajax.googleapis.com%2Fajax%2Flibs%2Fjquery%2F2.0.0%2Fjquery.min.js

[dmethvin]

I provided the file to Google as jquery-2.0.0.*, the sourcemap would need to be edited manually by Google to retarget the file name. Paul, did you guys do that last time? Or did I provide you one? The ASP.NET CDN uses the name name as we do with the embedded version so it doesn't affect them.

[dmethvin]

Looks like I did the job manually for 1.9.1 and sent them both (with and without version) but it didn't get into the build process; I wasn't sure which one they were using. So as I understand it from Google this can't be fixed, you'll need to use a local copy if you need the sourcemap.

[dmethvin]

So just in case it's not clear, this will be fixed by us in 2.0.1, but the current Google CDN version cannot be changed.

[dmethvin]

Whoops, just heard from them. They *are* changing the map, but whether you get it or not will depend on whether you or any intervening proxy has cached the old one forever.

[mattrobenolt]

FWIW, it seems my validator is able to fetch the right map from Google, but it appears 100% wrong. No idea how it's mapping every token up incorrectly. It's almost like it was built before the comment at the top of jquery.js was added.

[m_gol]

Hah, I've noticed the map file generated points to jquery.pre-min.js instead of jquery.js...

I'll look into it.

[m_gol]

Also, the spec changed so we should change the pragma accordingly to //# sourceMappingUrl

[mattrobenolt]

Hmm, I see the spec was updated May 16th. Is there a discussion around that I can follow?

[m_gol]

@up ​https://groups.google.com/forum/?fromgroups=#!topic/mozilla.dev.js-sourcemap/4uo7Z5nTfUY

[mattrobenolt]

Nice, thank you.

[dmethvin]

Yes, the -git versions need to have working map files so thanks m_gol. I think it's too early to change from //@ to //# but let's do that for 1.11/2.1 time frame. If Chrome hasn't changed to accept the new format by then, our change will be a motivator for it.

[m_gol]

Seems reasonable to wait for a pragma change until 1.11/2.1.

I submitted a pull request: ​https://github.com/jquery/jquery/pull/1275

I really need people to test it before we ship 1.10, this all is way too fragile.

[Michał Gołębiowski]

Fix #13793. Correct source map generation bugs. Close gh-1275.

Changeset: 997da31121b9d084ccba05a9bb1e258c8c8faaf0

[m_gol]

Landed at:
2.x-master: ​https://github.com/jquery/jquery/commit/997da31121b9d084ccba05a9bb1e258c8c8faaf0
1.x-master: ​https://github.com/jquery/jquery/commit/ce1a8295d7adf0bd5d6ab033243559b796a97e3d