getComputedStyle no longer works in node with jsdom

[m_gol]

I've noticed in this pull request:
​https://github.com/jquery/jquery/pull/1103
a change to the parameter passed to the main enclosing IIFE, i.e. window was changed to this. The problem is, there are lots of places in jQuery where we assume window is actually window so it breaks a lot. One example is in css.js:

// NOTE: we've included the "window" in window.getComputedStyle
// because jsdom on node.js will break without it.
function getStyles( elem ) {
	return window.getComputedStyle( elem, null );
}

So we have a few bytes (window.) that actually fix nothing. Another example is window.addEventListener etc.

[m_gol]

I meant "a few bytes that fix nothing", not "save".

[Rick Waldron]

What a nightmare. There are way too many places where we need window to be _window_

[m_gol]

Dave suggested we could just pass window instead of this and thus attach jQuery to window. jQuery is exported for node separately, anyway, so it shouldn't break.

If we need the global object inside, too, though, I see no other option than

(function ( global, window ) {
    /* code */
})( this, window );

[Timmy Willison]

If I understand this correctly, jQuery won't work without jsdom and its window export, which means using node's global object isn't sufficient on its own. So, just passing window and continuing to assign to module.exports in the outro is probably the best option.

[m_gol]

It's actually not src/outro, it's in src/exports.

Pull request: ​https://github.com/jquery/jquery/pull/1238

[Michał Gołębiowski]

Fixes #13760. Pass window, not this to the main IIFE. Closes gh-1238

Changeset: e80117adb49eff8f82140b01d755bdeefe7eb089