Bug Tracker

Opened 5 years ago

Closed 5 years ago

#13553 closed bug (fixed)

Leftover code for IE8 in effects.js

Reported by: m_gol Owned by:
Priority: undecided Milestone: None
Component: unfiled Version: git
Keywords: Cc:
Blocked by: Blocking:

Description

In src/effects.js in current jQuery 2.0.0pre in lines 443-452 there is code:

// Remove in 2.0 - this supports IE8's panic based approach
// to setting things on disconnected nodes

Tween.propHooks.scrollTop = Tween.propHooks.scrollLeft = {
	set: function( tween ) {
		if ( tween.elem.nodeType && tween.elem.parentNode ) {
			tween.elem[ tween.prop ] = tween.now;
		}
	}
};

I guess it should either be removed or the comment should be changed if it's still needed in 2.0.x.

Change History (2)

comment:1 Changed 5 years ago by m_gol

See https://github.com/jquery/jquery/pull/1195

Turns out IE9 still needs this workaround. (fortunately, it seems IE10 doesn't)

Last edited 5 years ago by m_gol (previous) (diff)

comment:2 Changed 5 years ago by Michał Z. Gołębiowski

Resolution: fixed
Status: newclosed

Edited comments and minor adjustments. Fixes #13553. Closes gh-1195.

Changeset: 79992d752393d80822a4f8be2b7bec3ecdd60f6a

Note: See TracTickets for help on using tickets.