#13331 closed bug (fixed)
jQuery.fn.add returns incorrect order in Chrome and Safari
| Reported by: | Owned by: | gibson042 | |
|---|---|---|---|
| Priority: | blocker | Milestone: | 1.10/2.0 |
| Component: | selector | Version: | 1.9.0 |
| Keywords: | Cc: | ||
| Blocked by: | Blocking: |
Description
When using jQuery.fn.add with items outside of the document the ordering is incorrect in Chrome and Safari.
Chrome returns in random order and Safari returns in reverse order.
I'm not actually sure if 'add' promises to maintain any logical order when elements aren't in the document but this didn't happen in jQuery 1.8.3 or below.
Discovered in Chrome 24.0.1312.56 m and Safari 5.1.7 on Windows 7.
Firefox 18.0.1 and IE 9 on Win 7 do not present this behavior.
Change History (9)
comment:1 Changed 10 years ago by
comment:2 Changed 10 years ago by
Taking a closer look at this and it appears the bug is with Sizzle.uniqueSort
comment:3 Changed 10 years ago by
| Component: | unfiled → selector |
|---|---|
| Milestone: | None → 1.9.1 |
| Owner: | set to gibson042 |
| Priority: | undecided → blocker |
| Status: | new → assigned |
Sizzle pull request at https://github.com/jquery/sizzle/pull/187 Webkit bug at https://bugs.webkit.org/show_bug.cgi?id=108274
comment:4 Changed 10 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Update Sizzle: detached node sorting in Webkit. Fixes #13331.
Changeset: 21c7a056e23cd30716db75a62fc7ad7dd23a334b
comment:5 Changed 10 years ago by
Update Sizzle: detached node sorting in Webkit. Fixes #13331.
Changeset: a8518c3bc4e1a8755c2d3a7be624b0e86be1070b
comment:6 Changed 10 years ago by
| Milestone: | 1.9.1 → 1.9.2 |
|---|
I should have noted it only happens when the one of the jQuery objects contains more than 10 elements.
And to rule out jQuery.fn.clone being the culprit: http://jsfiddle.net/M9EYX/4/