Skip to main content

Bug Tracker

Side navigation

#13283 closed bug (notabug)

Opened January 21, 2013 11:29AM UTC

Closed March 08, 2013 08:52PM UTC

Remove .andSelf() alias

Reported by: Nao Owned by:
Priority: low Milestone:
Component: traversing Version: 2.0b1
Keywords: Cc:
Blocked by: Blocking:

.andSelf() was turned into .addBack() in jQuery 1.8, and .andSelf was deprecated but still present in the source code as an alias.

Why not move this to the Migrate plugin and let people do the change manually? It's not exactly as hard to rewrite as for instance $.browser... It's just a name change... Doesn't make sense to waste extra bytes in jQuery 2.0 (and even 1.9) when it's all about making it slimmer.

Attachments (0)
Change History (5)

Changed January 21, 2013 07:10PM UTC by timmywil comment:1

component: unfiledtraversing
priority: undecidedlow
status: newopen
summary: Shouldn't .andSelf() be removed?Remove .andSelf() alias

Probably in 1.10 or 2.1 as users at least need some time before a method is completely removed. In the case of $.browser, it has been deprecated for a while.

Changed January 22, 2013 05:28PM UTC by dmethvin comment:2

Right, we didn't have this marked as deprecated so we should give people a bit more notice. It's not a lot of bytes anyway.

Changed February 27, 2013 04:00AM UTC by Nguyen Phuc Lam comment:3

Ref #13283, move .andSelf() to deprecated.js. Close gh-1170.

Changeset: 8bc7bdebefb23ef31247dda50012ee19ce9f58af

Changed March 08, 2013 08:32PM UTC by e0ne comment:4

Changed March 08, 2013 08:52PM UTC by dmethvin comment:5

resolution: → notabug
status: openclosed

Okay, I'll just close this for now. It's been deprecated and doesn't take many bytes, people can create custom builds without it. There is enough existing usage that I don't think we should remove it soon. We don't need PRs for this particular ticket.