Opened 6 years ago
Closed 6 years ago
#13283 closed bug (notabug)
Remove .andSelf() alias
| Reported by: | Nao | Owned by: | |
|---|---|---|---|
| Priority: | low | Milestone: | 1.next |
| Component: | traversing | Version: | 2.0b1 |
| Keywords: | Cc: | ||
| Blocked by: | Blocking: |
Description
http://bugs.jquery.com/ticket/9800
.andSelf() was turned into .addBack() in jQuery 1.8, and .andSelf was deprecated but still present in the source code as an alias.
Why not move this to the Migrate plugin and let people do the change manually? It's not exactly as hard to rewrite as for instance $.browser... It's just a name change... Doesn't make sense to waste extra bytes in jQuery 2.0 (and even 1.9) when it's all about making it slimmer.
Change History (5)
comment:1 Changed 6 years ago by
| Component: | unfiled → traversing |
|---|---|
| Milestone: | None → 1.next |
| Priority: | undecided → low |
| Status: | new → open |
| Summary: | Shouldn't .andSelf() be removed? → Remove .andSelf() alias |
comment:2 Changed 6 years ago by
Right, we didn't have this marked as deprecated so we should give people a bit more notice. It's not a lot of bytes anyway.
comment:3 Changed 6 years ago by
Ref #13283, move .andSelf() to deprecated.js. Close gh-1170.
Changeset: 8bc7bdebefb23ef31247dda50012ee19ce9f58af
comment:5 Changed 6 years ago by
| Resolution: | → notabug |
|---|---|
| Status: | open → closed |
Okay, I'll just close this for now. It's been deprecated and doesn't take many bytes, people can create custom builds without it. There is enough existing usage that I don't think we should remove it soon. We don't need PRs for this particular ticket.
Probably in 1.10 or 2.1 as users at least need some time before a method is completely removed. In the case of $.browser, it has been deprecated for a while.