Bug Tracker

Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#13160 closed bug (fixed)

Deferred.then doesn't propagete custom context

Reported by: nanto_vi Owned by: jaubourg
Priority: blocker Milestone: 1.9
Component: deferred Version: 1.9b1
Keywords: Cc:
Blocked by: Blocking:

Description

jQuery 1.9b1 changed a context (value of 'this') in piped promises.

This change affects codes that expect context to be propagated such as:

function ajaxWithRescueFrom404(settings) {
  return $.ajax(settings).then(null, function (xhr, status) {
    return (xhr.status === 404)
      ? $.Deferred().resolveWith(this, ['', status, xhr])
      : this;
  });
}

ajaxWithResuceFrom404({ url: ... }).done(function () {
  // Treat 404 response as same as succeeded response.
  // Expect that 'this' is a settings object.
});

The commit https://github.com/nanto/jquery/commit/cdac527be80fb2c6585ce6f53a83d4a9144fbf4d fixes this problem.

Change History (5)

comment:1 Changed 10 years ago by jaubourg

Component: unfileddeferred
Milestone: None1.9
Owner: set to jaubourg
Priority: undecidedblocker
Status: newassigned

Can you make this a full-fledged pull request with unit tests to boot?

comment:2 Changed 10 years ago by nanto_vi

comment:3 Changed 10 years ago by nanto_vi

Resolution: fixed
Status: assignedclosed

Propagete context of returned deferred object in Deferred.then(). Fixes #13160

Changeset: e7fdda981928befda72b78e9e2b17e33e232a603

comment:4 Changed 10 years ago by nanto

Propagate context of returned deferred object in Deferred.then(). Fixes #13160.

Changeset: 2f6b3f818fc51ee6ae44be69dc6b15b3d7a2dad4

comment:5 Changed 10 years ago by nanto

Propagate context of returned deferred object in Deferred.then(). Fixes #13160.

Changeset: 0c5d2fbabb39ef53a798535bc58690d34ea21351

Note: See TracTickets for help on using tickets.