#13089 closed bug (fixed)
support adds zoom style to body in Chrome/Safari
Reported by: | Owned by: | ||
---|---|---|---|
Priority: | blocker | Milestone: | 1.9.1 |
Component: | support | Version: | 1.9b1 |
Keywords: | Cc: | ||
Blocked by: | Blocking: |
Description
On any browser for which typeof div.style.zoom
isn't undefined
, body.style.zoom
is set to 1. Unfortunately, (at least) Chrome 24 and Safari 6 seem to support that property. Test case:
This is a regression from 1.8.3, introduced in https://github.com/jquery/jquery/pull/1025.
Change History (13)
comment:1 Changed 11 years ago by
Owner: | set to Zak Johnson <zakj@…> |
---|---|
Status: | new → pending |
comment:2 Changed 11 years ago by
Status: | pending → new |
---|
Confusion about who set the style and why. Aside from that, I don't know.
comment:3 Changed 11 years ago by
Component: | unfiled → support |
---|---|
Milestone: | None → 1.9 |
Priority: | undecided → low |
Status: | new → open |
It's unnecessary to set in Chrome and Safari at least.
comment:4 Changed 11 years ago by
Actually, Opera does support zoom, too (IMHO Firefox is the only significant browser that doesn't) but the style doesn't get applied there; what could be the reason?
comment:6 Changed 11 years ago by
This breaks the CSS grid in Chrome. Thanks for throwing a huge wrench in my already filled day.
comment:8 Changed 11 years ago by
Milestone: | 1.9 → 1.9.1 |
---|---|
Priority: | low → blocker |
comment:10 Changed 11 years ago by
Just including 'jquery-1.9.0.min.js' causes JS errors on Opera 12.12: 'Invalid value for property: zoom'
comment:11 Changed 11 years ago by
The commit, for reference:
https://github.com/jquery/jquery/commit/84629a9b876f6969777b43f3229b62b43bb624d2
We need to condition that by something that only applies in oldIE-land. There are a couple of support
properties in the vicinity.
comment:12 Changed 11 years ago by
Resolution: | → fixed |
---|---|
Status: | open → closed |
Fix #13089. Only apply zoom to IE6/7 body.
Changeset: 219a1935eea509bf147a05ef9d47502d8230991d
Does this cause any problem?