Skip to main content

Bug Tracker

Side navigation

#12957 closed feature (fixed)

Opened November 26, 2012 01:07AM UTC

Closed November 28, 2012 02:37AM UTC

Improve wrapMap

Reported by: markel Owned by: markel
Priority: low Milestone: 1.9
Component: manipulation Version: 1.8.3
Keywords: Cc:
Blocked by: Blocking:
Description

In most cases end tags are unnecessary and their absence make jQuery.buildFragment even more consistent across browsers, when jQuery.clean takes incorrect HTML argument as a string.

https://github.com/jquery/jquery/pull/1044

Attachments (0)
Change History (4)

Changed November 26, 2012 01:17AM UTC by rwaldron comment:1

In the PR provided, I don't see any proof of "more consistent across browsers". Some tests would be ideal, as what I _am_ seeing is the removal of a test, but no additions.

Changed November 26, 2012 01:30AM UTC by markel comment:2

@rwaldron If i add tests it would mean that jQuery can take "incorrect HTML argument as a string", which is not true.

Changed November 26, 2012 08:37PM UTC by timmywil comment:3

component: unfiledmanipulation
milestone: None1.9
owner: → markel
priority: undecidedlow
status: newassigned
version: git1.8.3

Changed November 28, 2012 02:37AM UTC by Oleg comment:4

resolution: → fixed
status: assignedclosed

Fix #12957. Simplify wrapMap, it doesn't need end tags. Close gh-1044.

Changeset: 9ae6b1a019553e95a6205d5c42ff7fa25e7a482e