Bug Tracker

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#12656 closed bug (fixed)

Make event shorthands an excludable module

Reported by: Rick Waldron Owned by:
Priority: low Milestone: 1.9.1
Component: build Version: 1.8.0
Keywords: Cc:
Blocked by: Blocking:

Description

Code should be using on/off anyway. The shorthands are just crufty.

Change History (10)

comment:1 Changed 5 years ago by Rick Waldron

Component: unfiledbuild
Milestone: None1.9
Owner: set to Rick Waldron
Priority: undecidedlow
Status: newassigned

comment:2 Changed 5 years ago by dmethvin

Me Gusta.

However, we're piggybacking on this to do the fixHooks. Perhaps we avoid the startup overhead and create some sort of eventHook[event.type] cache, only do the regex the first time we see a particular event.

comment:3 Changed 5 years ago by dmethvin

Dog-walk thought: In 2.0 we don't need a regex, we could base it on event instanceof MouseEvent etc.

comment:4 Changed 5 years ago by gibson042

We don't even need a regex now; the discrimination could be done purely by index in the static list.

comment:5 Changed 5 years ago by dmethvin

The static list is going to end up in the plugin so we couldn't depend on it being there.

comment:6 Changed 5 years ago by dmethvin

Milestone: 1.92.0
Owner: Rick Waldron deleted
Status: assignedopen

.. and by "plugin" I meant "module".

Seems like this would need to wait until 2.0 when we can reliably determine the event type, so I'm rescheduling it. rwaldron I'm bailing you out of the ticket, grab it again if you have time once we're on 2.0.

comment:7 Changed 5 years ago by dmethvin

The ajax events have similar code in ajax.js that could be moved to this "event shortcuts" module as well.

comment:8 Changed 5 years ago by Dave Methvin

Resolution: fixed
Status: openclosed

Fix #12656. Make event shorthands excludable.

Changeset: 6f7b6915bf457c413476faefb2159df717c2c210

comment:9 Changed 5 years ago by Dave Methvin

Fix #12656. Make event shorthands excludable.

Changeset: 24e76245544537e9f085e09d15d3b08efb171b4c

comment:10 Changed 5 years ago by dmethvin

Milestone: 2.01.9.1
Note: See TracTickets for help on using tickets.