jquery 1.8.2 fails ajax calls in IE9 because it assumes cross domain when default port is in ajax url

[benjamin.haentjens@…]

We upgraded from 1.7.2 to 1.8.2, and I was able to track down the offending javascript:

In version 1.7.2 we had this to test crossdomain:

crossDomain = !!( parts &&
	( parts[ 1 ] != ajaxLocParts[ 1 ] || parts[ 2 ] != ajaxLocParts[ 2 ] ||
		( parts[ 3 ] || ( parts[ 1 ] === "http:" ? 80 : 443 ) ) !=
			( ajaxLocParts[ 3 ] || ( ajaxLocParts[ 1 ] === "http:" ? 80 : 443 ) ) )

In version 1.8.2 we have this:

crossDomain = parts && ( parts.join(":") + ( parts[ 3 ] ? "" : parts[ 1 ] === "http:" ? 80 : 443 ) ) !==
	( ajaxLocParts.join(":") + ( ajaxLocParts[ 3 ] ? "" : ajaxLocParts[ 1 ] === "http:" ? 80 : 443 ) );

Notice how in 1.8.2 it also requires the [0] element of the array to be the same, this would not be the case for "​http://www.slashdot.org" and "​http://www.slashdot.org:80" for example.

A solution with minimal change would be this:

crossDomain = parts && ( parts.slice(1).join(":") + ( parts[ 3 ] ? "" : parts[ 1 ] === "http:" ? 80 : 443 ) ) !==
	( ajaxLocParts.slice(1).join(":") + ( ajaxLocParts[ 3 ] ? "" : ajaxLocParts[ 1 ] === "http:" ? 80 : 443 ) );

[jaubourg]

I though this was unit tested. Could you provide a jsFiddle demonstrating the issue?

If it's verified, then it's a case of size-optimization gone wrong.

[benjamin.haentjens@…]

Replying to jaubourg:

I though this was unit tested. Could you provide a jsFiddle demonstrating the issue?

If it's verified, then it's a case of size-optimization gone wrong.

A fiddle: ​http://jsfiddle.net/pqpT2/3/

[benjamin.haentjens@…]

Replying to jaubourg:

I though this was unit tested. If it's verified, then it's a case of size-optimization gone wrong.

I've added a fiddle unit test to the default set to demonstrate the problem in this fiddle: ​http://jsfiddle.net/gcRn7/

[jaubourg]

Woah, fantastic benjamin! Thanks so much for this. I owe you a beer now!

[gibson042]

Wow, I also thought it was tested, but benjamin is exactly right. Facepalm on my part for breaking it and for incomplete coverage.

[gibson042]

​https://github.com/jquery/jquery/pull/944

[dmethvin]

Fix #12635: restore 1.8.1 ajax crossDomain logic. Close gh-944.

Changeset: da3ff3afe4d8421ae4ad04d6653f04ed6d7768e3