Bug Tracker

Opened 11 years ago

Closed 10 years ago

#12569 closed bug (fixed)

Improve feature detect for oldIE event bubbling

Reported by: dmethvin Owned by: dmethvin
Priority: high Milestone: 1.9
Component: support Version: 1.8.0
Keywords: Cc:
Blocked by: Blocking:


From a Wikipedia edit:

For example, at least some of these scripts, including the latest at the time of this writing (see line 157 for example), base a critical decision regarding event bubbling on the presence of what is assumed to be an Internet Explorer? host method. Code comments in the immediate vicinity of the detection admit it is a browser sniff and confirm that the authors are trying to target Internet Explorer?. In reality, the method is found in other browsers (e.g. Opera).

A check for addEventListener should be sufficient.

Change History (10)

comment:1 Changed 11 years ago by dmethvin

Component: unfiledsupport
Milestone: None1.9
Priority: undecidedlow

Looks like some very opinionated jQuery hater got into the wiki: http://en.wikipedia.org/w/index.php?title=JQuery&diff=506984043&oldid=506975105

See the other comments by that IP on Wikipedia.

In any case, the appropriate place to report bugs is on the bug tracker, not by sniping on our Wikipedia entry.

comment:2 Changed 11 years ago by dmethvin

Status: newopen

comment:3 Changed 11 years ago by Merrifield, Jay

Resolution: fixed
Status: openclosed

Fixes #12569. Improve Feature Detect For oldIE bubbling. closes gh-967

Changeset: 063ea024e945adbeefbf88578f8ba424ca8a0939

comment:4 Changed 11 years ago by scottgonzalez

The multi-browser claim is complete BS. We're not trying to patch theoretical problems that may occur in a variety of non-standard event systems. We're trying to handle a case that is known to only exist with a specific non-standard event system. The old check is perfectly legitimate. We should revert this "fix" and close this as wontfix.

comment:5 Changed 11 years ago by dmethvin

Resolution: fixed
Status: closedreopened

Actually, the old and new code is broken. The UI test that broke was because jQuery.support.focusinBubbles is set to false by default. We're skipping the code to dispute that claim unless we're on IE. But recent Chrome does have a focusin event and we're shimming something we shouldn't shim--I haven't looked to see what the effects of that are: http://jsfiddle.net/dmethvin/NrKnF/ http://jsfiddle.net/dmethvin/2PdMu/

The reason we skip this test in the first place is that that setting inline handler attributes triggers errors when CSP features are enabled, and that affects Chrome.

comment:6 Changed 11 years ago by dmethvin

Owner: set to dmethvin
Priority: lowhigh
Status: reopenedassigned

comment:7 Changed 11 years ago by Dave Methvin

Resolution: fixed
Status: assignedclosed

Revert "Fixes #12569. Improve Feature Detect For oldIE bubbling. closes gh-967"

This reverts commit 063ea024e945adbeefbf88578f8ba424ca8a0939.

I've beaten on this for a while and can't find a suitable feature detect that catches Chrome's support for focusin.

Changeset: 05fb5de3ee1ea0610e95d2081aaab8702be651de

comment:8 Changed 11 years ago by dmethvin

Resolution: fixed
Status: closedreopened

comment:9 Changed 11 years ago by Timmy Willison

Status: reopenedassigned

comment:10 Changed 10 years ago by Oleg

Resolution: fixed
Status: assignedclosed

Fix #12569. Improve feature detect for event bubbling. Close gh-1076.

Changeset: c8c6ab6924b48832bfc2b94d40887b2f1b6c891e

Note: See TracTickets for help on using tickets.