Opened 11 years ago
Closed 11 years ago
#12519 closed bug (fixed)
Public API methods should not have private arguments
| Reported by: | dmethvin | Owned by: | |
|---|---|---|---|
| Priority: | high | Milestone: | 1.9 |
| Component: | core | Version: | 1.8.0 |
| Keywords: | Cc: | ||
| Blocked by: | Blocking: |
Description
Private variables make extending the API calls difficult. They also make duck punching impossible without at least recognizing and propagating the hidden vars, in cases like $.data() you have to actually understand the meaning of the pvt variable or you'll do the wrong thing. These can be replaced with a common private method that the two public methods ($.data() and $._data()) can call.
Examples:
data: function( elem, name, data, pvt /* Internal Use Only */ ) {
removeData: function( elem, name, pvt /* Internal Use Only */ )
attr: function( elem, name, value, pass ) {
Change History (3)
comment:1 Changed 11 years ago by
| Component: | unfiled → core |
|---|---|
| Milestone: | None → 1.9 |
| Priority: | undecided → high |
| Status: | new → open |
comment:2 Changed 11 years ago by
| Summary: | Public API methods should not have private variables → Public API methods should not have private arguments |
|---|
comment:3 Changed 11 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | open → closed |
Note: See
TracTickets for help on using
tickets.
Create private methods for processing data/removeData requests. Fixes #12519, Closes gh-976