Bug Tracker

Opened 5 years ago

Closed 5 years ago

#12283 closed bug (fixed)

jQuery 1.8 outerHeight is returning undefined instead of null

Reported by: PDSBGreg Owned by: mikesherov
Priority: blocker Milestone: 1.8.1
Component: dimensions Version: 1.8.0
Keywords: Cc:
Blocked by: Blocking:

Description

Moving from jQuery 1.7.2 to 1.8 has changed the return value for outerHeight. In 1.7.2, the outerHeight of an element that does not exist on a page returns null. As of 1.8, it returns undefined. So, equations that used to work in 1.7.2 now return NaN.

Here's a jsFiddle with 1.8 selected. http://jsfiddle.net/4eUJC/1/ Switch the jQuery version to 1.7.2 to see the previously expected (working) results.

Change History (4)

comment:1 Changed 5 years ago by timmywil

Component: unfileddimensions
Milestone: None1.8.1
Priority: undecidedblocker
Status: newopen

Yes, we should be returning null in these cases.

comment:2 Changed 5 years ago by mikesherov

Owner: set to mikesherov
Status: openassigned

comment:4 Changed 5 years ago by Mike Sherov

Resolution: fixed
Status: assignedclosed

Fix #12283. Return null for dimension getters on non elements. Fix gh-900.

Changeset: ad040181dc6c05fa37941a6c9bfbe98bdf7ba8f1

Note: See TracTickets for help on using tickets.