Skip to main content

Bug Tracker

Side navigation

#12283 closed bug (fixed)

Opened August 13, 2012 02:53PM UTC

Closed August 20, 2012 03:02AM UTC

jQuery 1.8 outerHeight is returning undefined instead of null

Reported by: PDSBGreg Owned by: mikesherov
Priority: blocker Milestone: 1.8.1
Component: dimensions Version: 1.8.0
Keywords: Cc:
Blocked by: Blocking:
Description

Moving from jQuery 1.7.2 to 1.8 has changed the return value for outerHeight. In 1.7.2, the outerHeight of an element that does not exist on a page returns null. As of 1.8, it returns undefined. So, equations that used to work in 1.7.2 now return NaN.

Here's a jsFiddle with 1.8 selected. http://jsfiddle.net/4eUJC/1/ Switch the jQuery version to 1.7.2 to see the previously expected (working) results.

Attachments (0)
Change History (4)

Changed August 13, 2012 03:36PM UTC by timmywil comment:1

component: unfileddimensions
milestone: None1.8.1
priority: undecidedblocker
status: newopen

Yes, we should be returning null in these cases.

Changed August 13, 2012 06:02PM UTC by mikesherov comment:2

owner: → mikesherov
status: openassigned

Changed August 19, 2012 08:30PM UTC by mikesherov comment:3

Changed August 20, 2012 03:02AM UTC by Mike Sherov comment:4

resolution: → fixed
status: assignedclosed

Fix #12283. Return null for dimension getters on non elements. Fix gh-900.

Changeset: ad040181dc6c05fa37941a6c9bfbe98bdf7ba8f1