Bug Tracker

Opened 5 years ago

Closed 5 years ago

#12148 closed bug (fixed)

hide event don't fire when toggle

Reported by: anonymous Owned by:
Priority: blocker Milestone: 1.8
Component: css Version: 1.8b2
Keywords: Cc:
Blocked by: Blocking:

Description

see http://jsfiddle.net/hQ6P2/1/ created hide event doesn't fire when toggle in jquery edge while it worked well for previous versions

Change History (2)

comment:1 Changed 5 years ago by dmethvin

Component: unfiledcss
Milestone: None1.8
Priority: undecidedblocker
Status: newopen

Yes, $.fn.toggle() doesn't call $.fn.hide() or $.fn.show() right now in 1.8, so it can't be duck punched.

comment:2 Changed 5 years ago by Dave Methvin

Resolution: fixed
Status: openclosed

Fix #12148. Let .toggle() call the public .hide() for punching.

There is a slightly shorter way to do this but it's not Closure-friendly.

Changeset: ed898c62c8d3e8c2091592976c181ee4142287ac

Note: See TracTickets for help on using tickets.