Uncaught TypeError: Object #<HTMLDocument> has no method 'getAttribute'

[musicisair@…]

$(document).is(".something");​ will throw Uncaught TypeError: Object #<HTMLDocument> has no method 'getAttribute'

​http://jsfiddle.net/musicisair/aUB7P/

tested on Chrome 20.0.1132.47 m

[dmethvin]

So what should we do about that? Are you looking for argument-specific error messages regarding all invalid inputs?

Error: this method does not take a document
Error: this method does not take a window
Error: this method does not take a plain object
Error: this method does not take a text node

​http://jsfiddle.net/AvgFU/

[mikesherov]

Document is never something. Insane inputs yield insane results.

[musicisair]

I know it is pointless to check if a document matches a class (or pretty much anything, really).

BUT ... It worked *as expected* in jQuery 1.8b1 and 1.7.2 (and probable many more versions).

Check ​http://jsfiddle.net/tQKZ7/1/ for a little context and my use case.

@dmethvin, All those cases work in 1.7.2: ​http://jsfiddle.net/AvgFU/1/

I'm all for jQuery being a little less forgiving when it comes to invalid input; however, since we often do things like $(event.target) and event.target can be a document, document should probably be supported here, IMO.

Also, in 1.8b2 (et al.):

$(document).is(document) === true $(document).is("div") === false $(document).is("[attr]") === false

[dmethvin]

All of that detail is missing from the original report, @musicair. It's helpful to state that you're reporting a regression, even if it's with invalid inputs, and what you'd like the actual behavior to be. I see your point on things like $(event.target) so I'll mark this open and we can discuss.

[Rick Waldron]

Blitzed!

This is a regression caused by the Sizzle rewrite.

[David Murdoch <musicisair@…>]

@dmethvin I guess I reduced the test case a little too far. I was assuming that any bug reports against a beta version would be for regressions, and that you all would assume the same. Sorry.

Honestly, I thought that document was valid input and that it was obvious that the example given should work. Which is why the ticket was so concise.

Related: ​http://bugs.jquery.com/ticket/10178

[dmethvin]

@musicair, definitely thanks for reporting it, I just didn't realize the context. We're already getting quite a few related reports like plugins doing $(-1).is(".jstree") and expecting a casual false reply. So as much as I'd like to keep at least some of those things in the totally invalid category it seems that we'd fill the bug tracker with complaints if we didn't change it back.

[gibson042]

​https://github.com/jquery/sizzle/pull/127

[Dave Methvin]

Update Sizzle; Closes #12054, #12057.

Changeset: 0bde43aeee5bed5fdfb5bffaecb8c1f43c8fdf19