script tags with type="text/ecmascript" leak into the DOM

[gibson042]

​http://jsfiddle.net/GaSua/

jQuery.clean has inconsistent logic for adding script elements to the result set vs. moving them into the scripts array: the former checks for no type or "text/javascript" or "text/ecmascript"; the latter only for no type or "text/javascript". As a result, those with type "text/ecmascript" are erroneously added to the result fragment and ultimately to the DOM.

[Rick Waldron]

RFC 4326 Defines "text/ecmascript" as obsolete

[gibson042]

So we should remove it from rscriptType, right?

[dmethvin]

Ideally we'd only remove script tags if the browser was going to "execute" them. I wonder if there is a simple feature detect for that. Or is it better to consistently remove scripts even if they aren't executed on the current browser? Seems like it's a dontcare if it doesn't execute.

[Rick Waldron]

ugh. I didn't actually mean to select "wont fix"

[gibson042]

​https://github.com/jquery/jquery/pull/680

[Rick Waldron]

As I said in the PR:

This does way more then address the bug in the ticket... I'm sorry, but after I re-opened the ticket, I wrote a test and tiny patch for this that only addresses the bug in question.

Minimal patch, directly addresses issue, includes tests: ​https://github.com/jquery/jquery/pull/681

[Rick Waldron waldron.rick@…]

Fix #11323. Consistently use rscriptType in jQuery.clean()

Changeset: f0732c1e4138342c96e35ff51d5cd681b6cfdb94