jQuery.fn.on: binding map with null selector ignores data

[zzzzbov]

Here's an example that will fail

var map,
    data;
map = {
    'foo': function (e) {
        //e.data will report `null` instead of `"bar"`
        console.log('data', e.data);
    }
};
data = 'bar';
$(window).on(map, null, data).trigger('foo');

The problem exists on line 3674

on: function( types, selector, data, fn, /*INTERNAL*/ one ) {
    var origFn, type;

    // Types can be a map of types/handlers
    if ( typeof types === "object" ) {
        // ( types-Object, selector, data )
        if ( typeof selector !== "string" ) { //3674
            // ( types-Object, data )
            data = selector;
            selector = undefined;
        }

It should probably read:

if ( typeof selector !== "string" && selector !== null ) {

Alternatively the docs need to be updated to address this difference:

​http://api.jquery.com/on/#on-events-map-selector-data

selector A selector string to filter the descendants of the selected elements that will call the handler. If the selector is null or omitted, the handler is always called when it reaches the selected element.

Should be changed to say:

If the selector is an empty string or omitted

[zzzzbov]

I've created a jsFiddle for this issue:

​http://jsfiddle.net/7M9cN/

[Rick Waldron]

Confirmed. I'll look into this now

[Rick Waldron]

​https://github.com/jquery/jquery/pull/652

[Rick Waldron]

Fix #11130: Don't neglect the data arg when event-map is passed.

Changeset: c0da49ff37484764bd0f33fe40d1a5f83d0f39e8