Bug Tracker

Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#11049 closed bug (fixed)

submit can not be stopped in ie when bubbling

Reported by: yiminghe Owned by: dmethvin
Priority: high Milestone: None
Component: event Version: 1.7.1
Keywords: Cc:
Blocked by: Blocking:


  1. input the following html:
<div id='t'>
    <form id='f'>
        <input type='submit' id='s'/>

<script src='jquery-1.7.1.js'></script>

        var ret=[];
        // trigger jquery's submit hack
  1. run it in ie

expected : alert(true)

actual result : alert(false)

PS : Maybe event "change" in ie has the same problem,i will check it later. PS2 : I try to fix this bug in KISSY (which learned a lot from jquery),hope it is feasible for jquery too.

  1. place event "submit" fix hander as the last handler always :



  1. do nothing in submit fix handler if user called stopPropagation in his handler:


After above fixes the result is fine :


Change History (7)

comment:1 Changed 11 years ago by yiminghe

sorry , open in ie and other browsers : http://jsfiddle.net/yiminghe/hFBng/

Last edited 11 years ago by yiminghe (previous) (diff)

comment:2 Changed 11 years ago by dmethvin

Owner: set to dmethvin
Status: newassigned

Yep, I agree about the bug. Making sure the event runs last will be tricky though, given that other code can attach events later.

comment:3 Changed 11 years ago by yiminghe

yes, it is tricky, especially making sure the submit fix event runs last always even user attach event later , so it need to modify "event add" , and record lastCount ,always place user's event handler before submit fix :


The above steps fix this bug perfectly, hope you can find a better way

comment:4 Changed 11 years ago by dmethvin

Component: unfiledevent
Priority: undecidedhigh

comment:5 Changed 11 years ago by Dave Methvin

Resolution: fixed
Status: assignedclosed

Fix #11049. Let bubbling submit be cancellable in oldIE.

Changeset: 92a92be10f2c6eecc93e0def9001a2ef2852fde1

comment:6 Changed 11 years ago by yiminghe

@Dave Methvin

Still not perfect :) , open in ie : http://jsfiddle.net/yiminghe/v9Zsq/

But i think the current solution is fine in real world.

comment:7 Changed 11 years ago by dmethvin

I agree, any inline handlers may not work properly. We try to make inline handlers work where possible, but they are bad practice and hard to fix since they are outside our event model. Thanks for your help yiminghe!

Note: See TracTickets for help on using tickets.