Allow traditional options object for $.Callbacks flags

[jaubourg]

This enhancement is quite simple. There is some concern about $.Callbacks flags being in a string format. I propose to accept objects as an alternative so that you could do both of the following:

$.Callbacks( "once memory" );
$.Callbacks({
    once: true,
    memory: true
});

[jaubourg]

+1

[dmethvin]

-1, I am not sure how this improves the interface (especially if we have to keep the old one) and I am pretty sure it will increase the size.

[jaubourg]

Replying to dmethvin:

-1, I am not sure how this improves the interface (especially if we have to keep the old one) and I am pretty sure it will increase the size.

We're basically talking about replacing:

flags = flags ? ( flagsCache[ flags ] || createFlags( flags ) ) : {};

with

flags = typeof flags === "string" ? ( flagsCache[ flags ] || createFlags( flags ) ) : ( flags || {} );

Are you being serious about the size Dave?

Regarding the gain, it's quite obviously easier and more natural to build an flags map compared to a string... not mention the possibility to add other (non-boolean) options in the future easily.

[Timmy Willison]

+1

[mikesherov]

-1, YAGNI. If we ever have a need for an object version, we can add it then.

[Rick Waldron]

+1

[dmethvin]

+1, Changing my vote if it's that small, although the Callbacks api footprint is still an issue

[jaubourg]

​https://github.com/jquery/jquery/tree/1.8/%2311011/Callbacks

[jaubourg]

Allows traditional options object for $.Callbacks flags. Fixes #11011. Unit tests added.

Changeset: 7fa0da08b88534e486ddb7eb3752ef76467fb7dd