#10931 closed enhancement (fixed)
Unit tests shouldn't require internet access
| Reported by: | gibson042 | Owned by: | |
|---|---|---|---|
| Priority: | low | Milestone: | 1.7.2 |
| Component: | build | Version: | 1.7.1 |
| Keywords: | Cc: | ||
| Blocked by: | Blocking: |
Description
I was working on jQuery while waiting for internet service to be restored today, and discovered an unexpected failure in the selector unit test module.
The "sizzle_cache" test loads data/selector/sizzle_cache.html, which requests http://code.jquery.com/jquery-git.js so it can store jQuery.noConflict(true) and then replace it from local files. But since the only purpose of this test is to check behavior with parallel copies of Sizzle, local sources should be sufficient for both jQuerys.
The test will pass without internet access if the request for jquery-git.js is replaced with local core.js + selector.js + traversing.js.
Change History (6)
comment:1 Changed 12 years ago by
| Priority: | undecided → low |
|---|---|
| Status: | new → open |
comment:2 Changed 12 years ago by
comment:4 Changed 12 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | open → closed |
Fix #10931: Make unit tests work without web access.
Applies https://github.com/gibson042/jquery/tree/10931 to
Changeset: 6c8dd7e7d3a00133591d4f9c05c207900234e11e
comment:5 Changed 12 years ago by
| Component: | unfiled → build |
|---|---|
| Milestone: | None → 1.7.2 |
comment:6 Changed 12 years ago by
- Changed from Review to Test Case rio orange portabilite du numero imc
- Status changed from reopened to closed comparateur forfait mobile forfait sans engagement forfait illimite sms illimite forfait internet mobile forfait bloque forfait blackberry
https://github.com/jquery/jquery/pull/622