Bug Tracker

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#10931 closed enhancement (fixed)

Unit tests shouldn't require internet access

Reported by: gibson042 Owned by:
Priority: low Milestone: 1.7.2
Component: build Version: 1.7.1
Keywords: Cc:
Blocked by: Blocking:

Description

I was working on jQuery while waiting for internet service to be restored today, and discovered an unexpected failure in the selector unit test module.

The "sizzle_cache" test loads data/selector/sizzle_cache.html, which requests http://code.jquery.com/jquery-git.js so it can store jQuery.noConflict(true) and then replace it from local files. But since the only purpose of this test is to check behavior with parallel copies of Sizzle, local sources should be sufficient for both jQuerys.

The test will pass without internet access if the request for jquery-git.js is replaced with local core.js + selector.js + traversing.js.

Change History (6)

comment:1 Changed 6 years ago by sindresorhus

Priority: undecidedlow
Status: newopen

comment:4 Changed 6 years ago by Richard Gibson

Resolution: fixed
Status: openclosed

comment:5 Changed 6 years ago by dmethvin

Component: unfiledbuild
Milestone: None1.7.2
Note: See TracTickets for help on using tickets.