Bug Tracker

Modify

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#10819 closed enhancement (fixed)

Eliminate "this.on.call(this, "

Reported by: anonymous Owned by: rwaldron
Priority: low Milestone: 1.7.2
Component: event Version: git
Keywords: Cc:
Blocked by: Blocking:

Description

one: function( types, selector, data, fn ) {
    return this.on.call( this, types, selector, data, fn, 1 );
},

can be simplified to:

one: function( types, selector, data, fn ) {
    return this.on( types, selector, data, fn, 1 );
},

since the this value is determined implicitly. Eliminating the extraneous .call(this, saves 10 bytes from the minified file.

Change History (3)

comment:1 Changed 5 years ago by rwaldron

  • Component changed from unfiled to event
  • Milestone changed from None to 1.next
  • Owner set to rwaldron
  • Priority changed from undecided to low
  • Status changed from new to assigned

comment:2 Changed 5 years ago by Rick Waldron

  • Resolution set to fixed
  • Status changed from assigned to closed

Remove unnec .call( this... from one: function() {}. Fixes #10819

Changeset: 64df670a81e70fdece1049129523bb2ad1bc2858

comment:3 Changed 5 years ago by dmethvin

  • Milestone changed from 1.next to 1.7.2

Please follow the bug reporting guidlines and use jsFiddle when providing test cases and demonstrations instead of pasting the code in the ticket.

Modify Ticket

Change Properties
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.