Bug Tracker

Opened 6 years ago

Closed 5 years ago

Last modified 5 years ago

#10819 closed enhancement (fixed)

Eliminate "this.on.call(this, "

Reported by: anonymous Owned by: Rick Waldron
Priority: low Milestone: 1.7.2
Component: event Version: git
Keywords: Cc:
Blocked by: Blocking:

Description

one: function( types, selector, data, fn ) {
    return this.on.call( this, types, selector, data, fn, 1 );
},

can be simplified to:

one: function( types, selector, data, fn ) {
    return this.on( types, selector, data, fn, 1 );
},

since the this value is determined implicitly. Eliminating the extraneous .call(this, saves 10 bytes from the minified file.

Change History (3)

comment:1 Changed 6 years ago by Rick Waldron

Component: unfiledevent
Milestone: None1.next
Owner: set to Rick Waldron
Priority: undecidedlow
Status: newassigned

comment:2 Changed 5 years ago by Rick Waldron

Resolution: fixed
Status: assignedclosed

Remove unnec .call( this... from one: function() {}. Fixes #10819

Changeset: 64df670a81e70fdece1049129523bb2ad1bc2858

comment:3 Changed 5 years ago by dmethvin

Milestone: 1.next1.7.2
Note: See TracTickets for help on using tickets.