Bug Tracker

Opened 12 years ago

Closed 11 years ago

#10799 closed bug (fixed)

Inconsistent results with [name="name"] selectors (also breaks .has)

Reported by: rgibson@… Owned by: rgibson@…
Priority: low Milestone: 1.8
Component: selector Version: 1.7
Keywords: Cc:
Blocked by: Blocking:


jQuery delivers inconsistent results with [name="name"] selectors because of optimization-driven dependence upon un-normalized results from document.getElementsByName (defined in DOM Level 2), whose behavior in Internet Explorer differs between "quirks" and "standards" modes (in "quirks" mode, the method will only return form controls: elements with tag names like INPUT/SELECT/etc.). Specifically, calls to jQuery with default/document scope will fail to include non-form controls on IE if and only if there is no DOCTYPE declaration and there are form controls that also match the selector.

Chrome, Firefox, and Safari do not limit the potential set of matching elements for document.getElementsByName regardless of DOCTYPE, and so do not exhibit this bug.

I've created demonstration pages for both no DOCTYPE and simple DOCTYPE cases. Expected behavior is for the following expressions to always return all elements with a matching name attribute, but observed behavior is that the simplest one returns only form controls when the browser is IE and there is no DOCTYPE declaration and there is at least one form control that matches the selector.

  • unscoped: $('*[name="named"]')
  • workaround: $('*:not([name!="named"])')
  • scoped: $('*[name="named"]', '#context')

Note that scoping to document.body would also avoid this bug because getElementsByName is only defined on the document level (see below for relevance), but unfortunately jQuery's has method is implemented with precisely the kind of unscoped call to jQuery that is problematic.

A possible fix would be something like jQuery.support.getByName (true if document.getElementsByName can return elements of any tag name) and corresponding tweaking of Sizzle.selectors.find.NAME (accessed in Sizzle.find as Expr.find[ type ] at line 4129 of the uncompressed jQuery-1.7.js) to always return null when getElementsByName is restricted. That is already the return value now when context is not a document, or when context is a document but getElementsByName returns an empty list, making this a very minor change.

Such a fix would add fewer than 100 bytes.

Change History (7)

comment:1 Changed 12 years ago by rgibson@…

Also note that the HTML5 Definition does not specify any "form control" exclusions, providing ample reason to implement a fix in jQuery.

comment:2 Changed 12 years ago by Timmy Willison

Component: unfiledselector
Milestone: None1.next
Priority: undecidedlow
Status: newopen

Confirmed, but we are not that concerned with quirksmode as it is not officially supported. We can look into this, but it is low priority.

reduced test case

comment:4 Changed 12 years ago by Timmy Willison

That is probably too much code to add for this edge case.

comment:5 Changed 12 years ago by rgibson@…

The change is two new if-blocks, each with a single-line body and one requiring a new temporary element, along with six lines of explanatory comments.

Also, I found out while fixing this that my initial guess about quirks mode vs. standards mode was incomplete, and a deeper issue is whether or not searches are handled with querySelectorAll (which makes it a bit broader). As shown at http://jsbin.com/uyezin/4, other conditions for incorrect results on Internet Explorer are:

  • no scope (equivalent to document scope)
  • both form and non-form elements in the document with the same name
  • selector incompatible with querySelectorAll (e.g., includes a psuedo selector)

Remembering that this bug counterintuitively breaks expressions like $set.has("[name=*]:visible"), what must change in order for a patch to be accepted?

comment:6 Changed 11 years ago by Timmy Willison

Milestone: 1.next1.8
Owner: set to rgibson@…
Status: openassigned

If you update the pull to fit with the rewrite, I'll probably land it.

comment:7 Changed 11 years ago by Timmy Willison

Resolution: fixed
Status: assignedclosed

Sizzle: detects a buggy getElementsByName. Fixes #10799.

Changeset: b325f7161c32a9dc8dfb49e5009af1b7f04ae276

Note: See TracTickets for help on using tickets.