Bug Tracker

Opened 10 years ago

Closed 10 years ago

#10705 closed bug (fixed)

off bug event name parser

Reported by: Math. Owned by: dmethvin
Priority: low Milestone: 1.7.1
Component: event Version: 1.7
Keywords: Cc:
Blocked by: Blocking:

Description

Adding an extra space at the end or at the beginning of the event name will reset all previous event attached to the element.

Fix: apply "trim" to event name.

See it in action: http://jsfiddle.net/8d6a6/

Change History (5)

comment:1 Changed 10 years ago by rodneyrehm

.off() also does not unbind multiple space separated elements as seen in this fiddle: http://jsfiddle.net/rodneyrehm/A5gvn/

comment:2 Changed 10 years ago by dmethvin

Component: unfiledevent
Milestone: None1.7.1
Owner: set to dmethvin
Priority: undecidedlow
Status: newassigned

comment:3 in reply to:  1 ; Changed 10 years ago by Math.

Replying to rodneyrehm:

.off() also does not unbind multiple space separated elements as seen in this fiddle: http://jsfiddle.net/rodneyrehm/A5gvn/

.off() also DOES unbind multiple space separated elements. You made a mistake, check: http://jsfiddle.net/A5gvn/2/

comment:4 in reply to:  3 Changed 10 years ago by rodneyrehm

Replying to Math.:

Replying to rodneyrehm:

.off() also does not unbind multiple space separated elements as seen in this fiddle: http://jsfiddle.net/rodneyrehm/A5gvn/

.off() also DOES unbind multiple space separated elements. You made a mistake, check: http://jsfiddle.net/A5gvn/2/

The docs state »One or more space-separated event types and optional namespaces, or just namespaces, such as "click", "keydown.myPlugin", or ".myPlugin".«

So I'd expect .off(".namespace1 .namespace2 click keyup.namespace3") to remove all events of namespace [namespace1, namespace2], all click events and the keyup events of namespace3.

That is currently not the case. If the above mixing is not intended to work, the docs should state that accordingly.

comment:5 Changed 10 years ago by Dave Methvin

Resolution: fixed
Status: assignedclosed

Fix #10705. Don't bail too soon in .off() event string processing.

Changeset: dd363d2c0f8d5eb03fe7beccff44a4a35887caa0

Note: See TracTickets for help on using tickets.