Skip to main content

Bug Tracker

Side navigation

#10701 closed bug (fixed)

Opened November 07, 2011 12:59PM UTC

Closed November 07, 2011 04:08PM UTC

Problems with submit forms using submit function

Reported by: anonymous Owned by: dmethvin
Priority: low Milestone: 1.7.1
Component: event Version: 1.7
Keywords: Cc:
Blocked by: Blocking:

On 1.7 form is posting even if onsubmit returns false. In 1.6.4 everithing was working good.

You can test it here:

When you click on "Submit" using 1.7 it will ask you to download bin file.

Firefox 7.0.1

Attachments (0)
Change History (4)

Changed November 07, 2011 02:34PM UTC by timmywil comment:1

component: unfiledevent
priority: undecidedlow
resolution: → invalid
status: newclosed

"return false" only works if you use jQuery to bind the handlers.

Changed November 07, 2011 03:06PM UTC by dmethvin comment:2

resolution: invalid
status: closedreopened

Yeah it just needs an extra check in .trigger().

The reason this got through, however, is that we consider inline handlers a wontfix item and don't have any unit tests for them. I will fix it but also point out that inline handlers do not always work reliably in jQuery because they're not under our control.

Changed November 07, 2011 03:06PM UTC by dmethvin comment:3

milestone: None1.7.1
owner: → dmethvin
status: reopenedassigned

Changed November 07, 2011 04:08PM UTC by Dave Methvin comment:4

resolution: → fixed
status: assignedclosed

Fix #10701, .preventDefault if an inline handler returns false.

Baby unicorns are slapped each time you use inline handlers, so do it sparingly.

Changeset: 90c907e8b65bc9d323863fc57389f2dca611292d