Problems with submit forms using submit function

[anonymous]

On 1.7 form is posting even if onsubmit returns false. In 1.6.4 everithing was working good.

You can test it here: ​http://jsfiddle.net/cxSmk/1/

When you click on "Submit" using 1.7 it will ask you to download bin file.

Firefox 7.0.1

[Timmy Willison]

"return false" only works if you use jQuery to bind the handlers.

​http://jsfiddle.net/timmywil/cxSmk/3/

[dmethvin]

Yeah it just needs an extra check in .trigger().

The reason this got through, however, is that we consider inline handlers a wontfix item and don't have any unit tests for them. I will fix it but also point out that inline handlers do not always work reliably in jQuery because they're not under our control.

[Dave Methvin]

Fix #10701, .preventDefault if an inline handler returns false.

Baby unicorns are slapped each time you use inline handlers, so do it sparingly.

Changeset: 90c907e8b65bc9d323863fc57389f2dca611292d