Opened 8 years ago
Closed 7 years ago
#10470 closed bug (fixed)
wrap() evaluates scripts
Reported by: | Owned by: | gibson042 | |
---|---|---|---|
Priority: | low | Milestone: | 1.9 |
Component: | manipulation | Version: | 1.6.4 |
Keywords: | Cc: | ||
Blocked by: | #11795 | Blocking: |
Description
Calling .wrap() will evaluate any scripts inside the element. This can cause problems when the browser has already run the scripts once. If this isn't considered a bug, it ought to be be mentioned in the documentation for wrap().
Workaround: manually do .remove('script') prior to using .wrap().
Change History (12)
comment:1 Changed 8 years ago by
Status: | new → open |
---|
comment:2 Changed 8 years ago by
comment:3 Changed 8 years ago by
The only way I can think of to fix this is to add an optional argument to domManip
(the function that wrap
ultimately relies upon) and then do something like:
if ( !ignoreScripts && scripts.length ) { jQuery.each( scripts, evalScript ); }
Does this seem reasonable? If so, I'm happy to write a patch.
comment:4 Changed 8 years ago by
Actually, it looks like wrap first reloads the script tags and only then removes them.
If you wrap an element containing a script element once, it is executed. You can now inspect the DOM and will find out the script element is missing. Thus, if you try to wrap the same element once more, the script is not executed.
Is there any reason to execute the scripts when the first wrap() is called, if it is always removed from the DOM by the same call?
Check:
http://jsfiddle.net/GYB76/1/
Tested in FF 8, Chrome 15, jQuery 1.7.1 and jQuery 1.4.1
comment:5 Changed 7 years ago by
Component: | unfiled → manipulation |
---|
comment:6 Changed 7 years ago by
Milestone: | None → 1.8.2 |
---|---|
Owner: | set to mikesherov |
Priority: | undecided → low |
Status: | open → assigned |
comment:7 Changed 7 years ago by
Milestone: | 1.8.2 → 1.9 |
---|
comment:8 Changed 7 years ago by
Blocked by: | 11795 added |
---|
comment:9 Changed 7 years ago by
Owner: | changed from mikesherov to gibson042 |
---|
comment:12 Changed 7 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Fix #11795, #10470: keep scripts in DOM; execute only on first insertion. Close gh-864.
Changeset: e889134058232c5e19156353c5fc3bf3b4915a94
Regarding the workaround, .remove('script') doesn't seem to work although .find('script').remove() does.