Opened 11 years ago
Closed 10 years ago
#10299 closed bug (fixed)
hrefNormalized === false also needs a propHook
Reported by: | Owned by: | Rick Waldron | |
---|---|---|---|
Priority: | blocker | Milestone: | 1.9 |
Component: | attributes | Version: | 1.6.4rc1 |
Keywords: | ie6 ie7 | Cc: | |
Blocked by: | Blocking: |
Description
jQuery always normalized the content attribute for href/src in IE6/7. Now we have prop and I think, jQuery should also normalize the href/-src-property.
In IE6/7 getting the href attribute should look like this (is already done by jQuery):
anchor.getAttribute('href', 2);
In IE6/7 getting the href property should look like this (should be done by jQuery):
anchor.getAttribute('href', 4);
I made a jsfiddle to document the problem:
http://jsfiddle.net/trixta/PH76V/
Please also have a look at the Microsoft documentation of getAttribute: http://msdn.microsoft.com/en-us/library/ms536429%28VS.85%29.aspx
Change History (10)
comment:1 Changed 11 years ago by
Component: | unfiled → attributes |
---|---|
Owner: | set to timmywil |
Status: | new → assigned |
comment:2 Changed 11 years ago by
Owner: | changed from timmywil to Rick Waldron |
---|---|
Priority: | undecided → low |
comment:3 Changed 11 years ago by
Milestone: | None → 1.8 |
---|
This ticket looks valid to me, seems like we need a propHook here. Given that it's for prehistoric browsers I'd be okay with inferring off the existing hrefNormalized detect rather than adding more code to support.js for it.
comment:4 Changed 11 years ago by
Keywords: | ie6 ie7 added |
---|
comment:5 Changed 10 years ago by
Milestone: | 1.8 → 1.8.1 |
---|---|
Priority: | low → blocker |
comment:6 Changed 10 years ago by
Milestone: | 1.8.1 → 1.9 |
---|
comment:7 Changed 10 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Fix #10299. Add a propHook for oldIE link href.
Changeset: 240b141a22c4783d619fc67c91f990d1535e7c57
comment:9 Changed 10 years ago by
Resolution: | fixed |
---|---|
Status: | closed → reopened |
The committed solution is invalid. The src and href attributes should return unaltered strings. We use getAttribute( "href", 2) to get the unaltered string. This should not be changed.
See the native behavior in a modern browser for support of what I'm talking about. http://jsbin.com/alebuq/1/
comment:10 Changed 10 years ago by
Resolution: | → fixed |
---|---|
Status: | reopened → closed |
Sorry, I have attributes on the mind.
@timmywil I haven't actually reviewed this issue or the fiddle