Bug Tracker

Ticket #9980 (closed enhancement: fixed)

Opened 3 years ago

Last modified 3 years ago

We can simplify the attr code by using getAttributeNode for everything in IE6/7

Reported by: timmywil Owned by:
Priority: low Milestone: 1.6.3
Component: attributes Version: 1.6.2
Keywords: Cc:
Blocking: Blocked by:

Description

Right now, the formHook(or the main hook for IE6/7 that uses getAttributeNode) is used in all of the cases that have been found to be absolutely necessary. The problem is, it's a lot of cases. Switching to getAttributeNode for everything in IE6/7 is safe, surprisingly removes the need for jQuery.attrFix completely (except to provide the tabIndex hook to both tabindex and tabIndex), and reduces the number of checks to see if getAttributeNode is needed. In IE6/7, getAttributeNode behaves almost exactly the same way as getAttribute in modern browsers.

Change History

comment:1 Changed 3 years ago by rwaldron

Hot damn.

comment:2 Changed 3 years ago by timmywil

  • Status changed from new to closed
  • Resolution set to fixed

Now using getAttributeNode in all attribute cases in IE6/7, which normalizes attribute behaviors across browsers, is less hacky, and shortens the attribute code. Fixes #9980.

Changeset: 8c2cb49917fc1082abac0a26298b992dcd6a5b6e

comment:3 Changed 3 years ago by timmywil

  • Milestone changed from None to 1.6.3

comment:4 Changed 3 years ago by timmywil

  • Priority changed from undecided to low
  • Component changed from unfiled to attributes

comment:5 Changed 3 years ago by Philip Jägenstedt <philip@…>

This commit caused the behavior of .attr('foo') to change for markup like <div foo></div>. Here's what I used to bisect my way here:

<span itemscope></span> <script> alert($('span').attr('itemscope') == "" ? 'good' : 'bad'); </script>

This appears to have been fixed in a later release, but I can't see it linked from here.

Note: See TracTickets for help on using tickets.