Ticket #9499 (closed bug: fixed)
removeClass will only remove the first instance of a class
| Reported by: | theallan | Owned by: | timmywil |
|---|---|---|---|
| Priority: | high | Milestone: | 1.6.2 |
| Component: | attributes | Version: | 1.6.1 |
| Keywords: | Cc: | ||
| Blocking: | Blocked by: |
Description
I've just been debugging an issue in my software where adding and removing classes with addClass and removeClass were doing something slightly odd. I realised that while addClass will add multiple instances of a class to an element (fair enough, I've asked it to do that), removeClass will only remove the first instance of a class. I would have expected it to remove all instances of the given class (although this could be an incorrect assumption on my part). For example
$("#test1").addClass("disabled disabled"); alert("test1 class after addClass ='"+$("#test1").attr("class")+"'");
$("#test1").removeClass("disabled"); alert("test1 class after removeClass ='"+$("#test1").attr("class")+"'");
The first alert will give "disabled disabled" while the second alert gives "disabled". I had anticipated it just being an empty string.
Change History
comment:2 Changed 2 years ago by rwaldron
- Owner set to rwaldron
- Priority changed from undecided to high
- Status changed from new to assigned
- Component changed from unfiled to attributes
@ajpiano and I agree: addClass should not allow you to add the same class twice
comment:3 Changed 2 years ago by timmywil
- Owner changed from rwaldron to timmywil
- Milestone changed from 1.next to 1.7
comment:5 Changed 2 years ago by timmywil
- Status changed from assigned to closed
- Resolution set to fixed
Check classes passed for duplicates. Fixes #9499.
Changeset: db437be6e31c924aade13bb719f9facc122b3d9c
Please follow the bug reporting guidlines and use jsFiddle when providing test cases and demonstrations instead of pasting the code in the ticket.

jsFiddle example: http://jsfiddle.net/EvcfC/
Possibly similar to bug #6914.