Bug Tracker

#9147 closed bug (fixed)

Opened May 06, 2011 01:44PM UTC

Closed May 06, 2011 04:10PM UTC

Variable tmp in promise implicitly declared?

Reported by: johnwilander Owned by:
Priority: blocker Milestone: 1.6.1
Component: queue Version: 1.6
Keywords: Cc:
Blocked by: Blocking:
Description

It seems the variable tmp in promise is implicitly declared (jquery-1.6.js line 1861). If you enter "use strict"; in the beginning of the file that variable becomes a strict mode violation.

In unminified code:

if (( tmp = jQuery.data( elements[ i ], deferDataKey, undefined, true ) ||

In minified code:

while (g--)if (tmp = f.data(e[g], i, b, !0)

Regards, John Wilander

Attachments (0)
Change History (3)

Changed May 06, 2011 04:05PM UTC by timmywil comment:1

component: unfiled → queue
milestone: 1.next → 1.6.1
priority: undecided → blocker
status: new → open

Thanks! I think you're right. L158 of queue.js

Changed May 06, 2011 04:07PM UTC by jaubourg comment:2

Oh! The shameful moment :/

Thanks for having caught this one John.

Changed May 06, 2011 04:10PM UTC by timmywil comment:3

resolution: → fixed
status: open → closed

tmp was global in the new fn.promise. Fixes #9147.

Changeset: f7f8450041df7c250f04b03cbbcbd2d01025f379