Bug Tracker

Ticket #9147 (closed bug: fixed)

Opened 4 years ago

Last modified 4 years ago

Variable tmp in promise implicitly declared?

Reported by: johnwilander Owned by:
Priority: blocker Milestone: 1.6.1
Component: queue Version: 1.6
Keywords: Cc:
Blocking: Blocked by:

Description

It seems the variable tmp in promise is implicitly declared (jquery-1.6.js line 1861). If you enter "use strict"; in the beginning of the file that variable becomes a strict mode violation.

In unminified code:

if (( tmp = jQuery.data( elements[ i ], deferDataKey, undefined, true )

In minified code:

while (g--)if (tmp = f.data(e[g], i, b, !0)

Regards, John Wilander

Change History

comment:1 Changed 4 years ago by timmywil

  • Priority changed from undecided to blocker
  • Status changed from new to open
  • Component changed from unfiled to queue
  • Milestone changed from 1.next to 1.6.1

Thanks! I think you're right. L158 of queue.js

comment:2 Changed 4 years ago by jaubourg

Oh! The shameful moment :/

Thanks for having caught this one John.

comment:3 Changed 4 years ago by timmywil

  • Status changed from open to closed
  • Resolution set to fixed

tmp was global in the new fn.promise. Fixes #9147.

Changeset: f7f8450041df7c250f04b03cbbcbd2d01025f379

Note: See TracTickets for help on using tickets.