.css and .style call adds "px" to widows a orphans style prop which are both "number only"; crash in IE

Reported by:	woelfela@gmail.com	Owned by:	rwaldron
Priority:	blocker	Milestone:	1.next
Component:	css	Version:	1.5.2
Keywords:		Cc:
Blocked by:		Blocking:

Description

According the WC3 definition for CSS2.1 the styles "widows"

and "orphans" use the type integer.

Under IE9 the styles are saved inside the "DispHTMLStyle" type which controls the passed value types for the styles applied via myDom.css() and myDom.style()

Solution:

the JSON in jquery-1.5.2.js:5795 needs to be extended by the additional keywords "widows" and "orphans"

jquery-1.5.2.js:5795 =>

// Exclude the following css properties to add px
cssNumber: {
	"zIndex": true,
	"fontWeight": true,
	"opacity": true,
	"zoom": true,
	"lineHeight": true
},

Attachments (0)

Change History (4)

Changed April 21, 2011 12:27PM UTC by rwaldron comment:1

component:	unfiled → css
owner:	→ rwaldron
status:	new → assigned

pull request momentarily

Changed April 21, 2011 02:36PM UTC by rwaldron comment:2

priority:	undecided → blocker

Changed April 21, 2011 03:38PM UTC by rwaldron comment:3

https://github.com/jquery/jquery/pull/340

Changed April 22, 2011 04:02AM UTC by Rick Waldron comment:4

resolution:	→ fixed
status:	assigned → closed

Landing pull request 340. Adds widows, orphans to cssNumber hash; includes tests. Fixes #8936.

More Details:

Changeset: 3d9445e3fce84448b4b569a1a6f1aa454a898265

Side navigation