Bug Tracker

Modify

Ticket #8145 (closed enhancement: fixed)

Opened 3 years ago

Last modified 2 years ago

jQuery.readyWait Standalone Test Page

Reported by: rwaldron Owned by: jrburke
Priority: high Milestone: 1.5.1
Component: event Version: 1.5
Keywords: Cc:
Blocking: #8141 Blocked by:

Description

Per -dev discussion, James Burke is going to provide us with a standalone test case for the jQuery.readyWait implementation

Change History

comment:1 Changed 3 years ago by rwaldron

  • Owner set to jrburke
  • Status changed from new to assigned

comment:2 Changed 3 years ago by rwaldron

  • Blocking 8141 added

comment:3 Changed 3 years ago by dmethvin

Documentation for jQuery.holdReady is here (must be logged in):  http://api.jquery.com/?p=3779&preview=true

comment:4 Changed 3 years ago by jrburke

I just put two commits in my fork and did a pull request, but since I had a previous pull request, it seems to show the commits I did for #7102, some of which were merged but then later reverted. The pull request is here:

 https://github.com/jquery/jquery/pull/166

but I really just want the last two commits in that pull request for this ticket:

 https://github.com/jrburke/jquery/commit/4bcd5f81b1af9fc3a489c17125ea1edbbc323c5d

 https://github.com/jrburke/jquery/commit/98112604dc31588bbe9c6f70ed29765b798efdf0

I apologize for my lack of GitHub skills, if someone has a clue on how to fix the pull request, I'm happy to do it. I'm thinking I will just delete my fork and start over fresh, but give a holler if there is a trick to get the existing thing to work.

I tested the readywait.html and readywait2.html with rwaldron's fix mentioned above for #8141 and it works, but just did a cursory test in IE6, Safari 5 and Firefox 4 beta.

comment:5 Changed 3 years ago by jitter

  • Priority changed from undecided to high
  • Component changed from unfiled to event
  • Milestone changed from 1.next to 1.5.1

Hi, thanks for the tests (didn't try them yet) but I guess dave and/or rick will later on.

For your "problems" with the pull request. It basically boils down to the fact that you did all your changes on the "master" branch instead of using a separate branch for separate changes.

This is briefly touched upon in  Tips for jQuery Bug Patching. If you need more info on how to: clean up your master branch, resync with jquery-master, make separate branches and pulling over the commits you made to those branches I guess it's easiest if you hit us on irc.

comment:6 Changed 3 years ago by rwaldron

Handing these off to dmethvin to match with his readyWait/readyHold patch

 https://github.com/jquery/jquery/pull/222

comment:7 Changed 3 years ago by jrburke

jitter: thanks for the pointers, that makes perfect sense, and something I should have looked for before.

rwaldron: thanks for cleaning up my github mess. I'll do better next time.

comment:8 Changed 3 years ago by jrburke

  • Status changed from assigned to closed
  • Resolution set to fixed

Add readyWait tests. Fixes #8145.

Adds tests for the fix to #6781.

Changeset: d99268a4b728e47d02b9b893e08796c8060a68e9

Please follow the  bug reporting guidlines and use  jsFiddle when providing test cases and demonstrations instead of pasting the code in the ticket.

View

Add a comment

Modify Ticket

Action
as closed
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.