Bug Tracker

Modify

Ticket #8017 (closed bug: fixed)

Opened 3 years ago

Last modified 3 years ago

$.fn.domManip woes - 1.5b is 80% slower

Reported by: danheberden Owned by: rwaldron
Priority: blocker Milestone: 1.5
Component: manipulation Version: 1.5b1
Keywords: Cc:
Blocking: Blocked by:

Description

 http://jsperf.com/dh-dommanip-tribulations

it's not clone ( http://jsperf.com/dh-jquery-1-5b-clone) - but it is. Using clone when it shouldn't be run is making for a huge perf hit.

Stemmed from: #8013

Change History

comment:1 Changed 3 years ago by jitter

  • Priority changed from undecided to blocker
  • Status changed from new to open
  • Component changed from unfiled to manipulation

comment:2 Changed 3 years ago by danheberden

Here's the perf/fix with rwaldrons goodies:  http://jsperf.com/dh-dommanip-tribulations/3

comment:3 Changed 3 years ago by john

  • Milestone changed from 1.next to 1.5

comment:4 Changed 3 years ago by john

See also: #8013.

comment:5 Changed 3 years ago by rwaldron

  • Owner set to rwaldron
  • Status changed from open to assigned

I've abstracted copyCloneEvent to accept a single origin and clone DOM node, instead of collections. This frees us from making any calls to find("*"). Created jQuery.clone( elem, [ dataAndEvents, deepDataAndEvents ]) which acts as the brains for jQuery.fn.clone(). [ dataAndEvents, deepDataAndEvents ] Are both true by default.

 https://github.com/jquery/jquery/pull/200

Last edited 3 years ago by rwaldron (previous) (diff)

comment:6 Changed 3 years ago by john

  • Status changed from assigned to closed
  • Resolution set to fixed

Landed.

Please follow the  bug reporting guidlines and use  jsFiddle when providing test cases and demonstrations instead of pasting the code in the ticket.

View

Add a comment

Modify Ticket

Action
as closed
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.