Skip to main content

Bug Tracker

Side navigation

#8017 closed bug (fixed)

Opened January 20, 2011 02:01AM UTC

Closed January 21, 2011 04:20PM UTC

$.fn.domManip woes - 1.5b is 80% slower

Reported by: danheberden Owned by: rwaldron
Priority: blocker Milestone: 1.5
Component: manipulation Version: 1.5b1
Keywords: Cc:
Blocked by: Blocking:
Description

http://jsperf.com/dh-dommanip-tribulations

it's not clone (http://jsperf.com/dh-jquery-1-5b-clone) - but it is. Using clone when it shouldn't be run is making for a huge perf hit.

Stemmed from: #8013

Attachments (0)
Change History (6)

Changed January 20, 2011 02:08AM UTC by jitter comment:1

component: unfiledmanipulation
priority: undecidedblocker
status: newopen

Changed January 20, 2011 04:19PM UTC by danheberden comment:2

Here's the perf/fix with rwaldrons goodies: http://jsperf.com/dh-dommanip-tribulations/3

Changed January 21, 2011 02:20PM UTC by john comment:3

milestone: 1.next1.5

Changed January 21, 2011 02:20PM UTC by john comment:4

See also: #8013.

Changed January 21, 2011 04:19PM UTC by rwaldron comment:5

_comment0: I've abstracted copyCloneEvent to accept a single origin and clone DOM node, instead of a collection. This frees us from making any calls to find("*"). Created jQuery.clone( elem, [ dataAndEvents, deepDataAndEvents ]) which acts as the brains for jQuery.fn.clone(). [ dataAndEvents, deepDataAndEvents ] Are both true by default. \ \ https://github.com/jquery/jquery/pull/2001295626774745436
owner: → rwaldron
status: openassigned

I've abstracted copyCloneEvent to accept a single origin and clone DOM node, instead of collections. This frees us from making any calls to find("*"). Created jQuery.clone( elem, [ dataAndEvents, deepDataAndEvents ]) which acts as the brains for jQuery.fn.clone(). [ dataAndEvents, deepDataAndEvents ] Are both true by default.

https://github.com/jquery/jquery/pull/200

Changed January 21, 2011 04:20PM UTC by john comment:6

resolution: → fixed
status: assignedclosed

Landed.