Side navigation
#7979 closed enhancement (fixed)
Opened January 15, 2011 04:32AM UTC
Closed January 27, 2011 06:35PM UTC
Last modified February 22, 2011 01:11PM UTC
subclass enhancment
| Reported by: | digitalxero@gmail.com | Owned by: | wycats |
|---|---|---|---|
| Priority: | blocker | Milestone: | 1.5 |
| Component: | core | Version: | 1.5b1 |
| Keywords: | Cc: | ||
| Blocked by: | Blocking: |
Description
Currently the only top level method that a jQuery subclass gets is 'subclass'. With a small patch you really get a full jQuery subclass and subclassing the subclass does what you would expect and brings over any top level methods/attributes you defined on your subclass.
Patch/Tests @ http://jsfiddle.net/mjTy6/
Attachments (0)
Change History (11)
Changed January 15, 2011 02:55PM UTC by comment:1
| component: | unfiled → core |
|---|---|
| type: | bug → enhancement |
Changed January 15, 2011 07:58PM UTC by comment:2
Added Pull Request https://github.com/jquery/jquery/pull/184
Changed January 16, 2011 05:58PM UTC by comment:3
| keywords: | → needsreview |
|---|
Changed January 17, 2011 12:29AM UTC by comment:4
| cc: | → wycats |
|---|
Changed January 23, 2011 10:35AM UTC by comment:5
I would actually consider this a bug in the current subclass implementation as you are not getting a subclass of jQuery you are getting a subclass of jQuery.fn
Changed January 27, 2011 06:32PM UTC by comment:7
| milestone: | 1.next → 1.5 |
|---|---|
| owner: | → wycats |
| priority: | undecided → blocker |
| status: | new → assigned |
Changed January 27, 2011 06:35PM UTC by comment:8
| resolution: | → fixed |
|---|---|
| status: | assigned → closed |
Make sure subclass is a proper subclass not just subclassing the fn methods. Fixes #7979.
Changeset: e00f74c43bf58132be01c6417c6126a5bc085899
Changed January 27, 2011 06:50PM UTC by comment:9
| cc: | wycats |
|---|---|
| keywords: | needsreview |
Changed February 22, 2011 12:28PM UTC by comment:10
#5880 is a duplicate of this ticket.
Changed February 22, 2011 01:11PM UTC by comment:11
I am not positive that #5880 is in fact a duplicate of this issue. Perhaps I'm misunderstanding, but please review this comment:
Thanks for taking the time to contribute to the jQuery project by writing an enhancement request.
It would be good (and give this suggestion more visibility) if you would file a pull request for this with the changes you made. If you don't know how to do this check
http://docs.jquery.com/Getting_Involved the "Committing and Pull Requests" section and \\\\
http://docs.jquery.com/Tips_for_jQuery_Bug_Patching
for more information