Skip to main content

Bug Tracker

Side navigation

#7226 closed bug (fixed)

Opened October 17, 2010 02:28PM UTC

Closed October 17, 2010 03:43PM UTC

Last modified March 19, 2012 09:21PM UTC

clone on line 372 is declared implicitly

Reported by: kdavis@gilt.com Owned by:
Priority: undecided Milestone: 1.4.4
Component: unfiled Version: 1.4.3
Keywords: Cc:
Blocked by: Blocking:
Description

if ( copyIsArray ) {

copyIsArray = false;

clone = src && jQuery.isArray(src) ? src : [];

} else {

clone = src && jQuery.isPlainObject(src) ? src : {};

}

// Never move original objects, clone them

target[ name ] = jQuery.extend( deep, clone, copy );

Attachments (0)
Change History (3)

Changed October 17, 2010 02:37PM UTC by kdavis@gilt.com comment:1

diff --git a/public/javascripts/vendor/jquery.1.4.3.js b/public/javascripts/vendor/jquery.1.4.3.js

index 84a82f6..c32216a 100644

--- a/public/javascripts/vendor/jquery.1.4.3.js

+++ b/public/javascripts/vendor/jquery.1.4.3.js

@@ -331,7 +331,7 @@ jQuery.fn.init.prototype = jQuery.fn;

jQuery.extend = jQuery.fn.extend = function() {

copy reference to target object

  • var target = arguments[0] || {}, i = 1, length = arguments.length, deep = false, options, name, src, copy, copyIsArray;

+ var target = arguments[0] || {}, i = 1, length = arguments.length, deep = false, options, name, src, copy, copyIsArray, clone;

Handle a deep copy situation

if ( typeof target === "boolean" ) {

Changed October 17, 2010 02:38PM UTC by kdavis@gilt.com comment:2

okay, that diff didn't come thru very well

Changed October 17, 2010 03:43PM UTC by John Resig comment:3

resolution: → fixed
status: newclosed

Var wasn't being explicitly declared. Fixes #7226.

Changeset: a7d0b0b9e887782bf1ed795152a845da87729c52